Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 1699050: code review 1699050: Added Bazaar+Launchpad support in goinstall (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by niemeyer
Modified:
10 years, 4 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Added Bazaar+Launchpad support in goinstall With these changes, goinstall is now able to use branches maintained with Bazaar located in Launchpad. Project aliases such as /project and /project/series are supported in addition to specific user or team branches such as /~user/project/branch. Temporary branches under the +junk special project are also supported. As a curious side effect, since Launchpad is able to import code from other locations, they can be indirectly accessible too if desired.

Patch Set 1 #

Patch Set 2 : code review 1699050: Added Bazaar+Launchpad support in goinstall #

Total comments: 6

Patch Set 3 : code review 1699050: Added Bazaar+Launchpad support in goinstall #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -43 lines) Patch
M src/cmd/goinstall/doc.go View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/cmd/goinstall/download.go View 1 2 3 chunks +78 lines, -42 lines 0 comments Download
M src/cmd/goinstall/main.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
niemeyer
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
10 years, 4 months ago (2010-06-26 17:29:53 UTC) #1
rsc1
looks pretty good; thanks http://codereview.appspot.com/1699050/diff/2001/3001 File src/cmd/goinstall/doc.go (right): http://codereview.appspot.com/1699050/diff/2001/3001#newcode45 src/cmd/goinstall/doc.go:45: Launchpad wrong indentation http://codereview.appspot.com/1699050/diff/2001/3002 File ...
10 years, 4 months ago (2010-06-28 21:17:44 UTC) #2
niemeyer
Thanks for the review. Changes addressed. http://codereview.appspot.com/1699050/diff/2001/3001 File src/cmd/goinstall/doc.go (right): http://codereview.appspot.com/1699050/diff/2001/3001#newcode45 src/cmd/goinstall/doc.go:45: Launchpad On 2010/06/28 ...
10 years, 4 months ago (2010-06-28 21:46:30 UTC) #3
niemeyer
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 4 months ago (2010-06-28 21:48:20 UTC) #4
rsc1
LGTM Could you please complete the CLA as described at http://golang.org/doc/contribute.html#copyright ? Thanks.
10 years, 4 months ago (2010-06-30 21:51:27 UTC) #5
gustavo_niemeyer.net
> Could you please complete the CLA as described at > http://golang.org/doc/contribute.html#copyright ? I've already ...
10 years, 4 months ago (2010-06-30 22:24:15 UTC) #6
rsc
On Wed, Jun 30, 2010 at 15:23, Gustavo Niemeyer <gustavo@niemeyer.net> wrote: >> Could you please ...
10 years, 4 months ago (2010-07-01 00:19:01 UTC) #7
gustavo_niemeyer.net
> 3. Add you to the CONTRIBUTORS file with both addresses. > The Mercurial plugin ...
10 years, 4 months ago (2010-07-01 01:40:48 UTC) #8
rsc
10 years, 4 months ago (2010-07-01 06:33:52 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=3db9a916a3fe ***

goinstall: support for Bazaar+Launchpad

With these changes, goinstall is now able to use branches
maintained with Bazaar located in Launchpad.

Project aliases such as /project and /project/series are
supported in addition to specific user or team branches
such as /~user/project/branch.  Temporary branches under
the +junk special project are also supported.

As a curious side effect, since Launchpad is able to import
code from other locations, they can be indirectly
accessible too if desired.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1699050

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b