Issue 169660043: page-breaking: allow degenerate scores; issue 4161

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 169660043: page-breaking: allow degenerate scores; issue 4161

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by Keith

Modified:
9 years, 5 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

page-breaking: allow degenerate scores; issue 4161 Reverses part of fb5d36ef6d026fdaa2b5d6c207eefd39374bff97 that was trying to avoid zero-length chunks, because after 255fe22c663dbbcb25b693fc8e60ca95343417ef we have to deal with zero-length chunks.

Patch Set 1 #

Total comments: 1

Patch Set 2 : test last corner case #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lily/page-breaking.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dak

9 years, 5 months ago (2014-11-16 09:00:51 UTC) #1

https://codereview.appspot.com/169660043/diff/1/lily/page-breaking.cc
File lily/page-breaking.cc (right):

https://codereview.appspot.com/169660043/diff/1/lily/page-breaking.cc#newcode834
lily/page-breaking.cc:834: printf("\nQQQQQQQQQQQqqqq min_system_count %d", ret);
Uh, that one looks like a leftover.

Expand All Messages | Collapse All Messages