Issue 169630043: [dev.power64] code review 169630043: 9g: fix Solaris build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 169630043: [dev.power64] code review 169630043: 9g: fix Solaris build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by austin

Modified:
9 years, 5 months ago

Reviewers:
minux

CC:
rsc, minux, golang-codereviews

Visibility:
Public.

Description

liblink: fix Solaris build a->class is a char. Boo hoo.

Patch Set 1 #

Patch Set 2 : diff -r 776e2cb1a1f369115a176a2749909d4a71e0dd64 https://code.google.com/p/go #

Patch Set 3 : diff -r 776e2cb1a1f369115a176a2749909d4a71e0dd64 https://code.google.com/p/go #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/liblink/list6.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

austin

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...

9 years, 5 months ago (2014-11-14 19:39:04 UTC) #1

minux

LGTM. Shouldn't the description start with "liblink:" instead of always "9g:"?

9 years, 5 months ago (2014-11-14 20:46:56 UTC) #2

austin

Oops. Muscle memory. :) Fixed. On Fri, Nov 14, 2014 at 3:46 PM, minux <minux@golang.org> ...

9 years, 5 months ago (2014-11-14 20:51:53 UTC) #3

austin

9 years, 5 months ago (2014-11-14 20:53:25 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=f57928630b36 ***

[dev.power64] liblink: fix Solaris build

a->class is a char.  Boo hoo.

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://codereview.appspot.com/169630043

Expand All Messages | Collapse All Messages