Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1671)

Issue 169630043: [dev.power64] code review 169630043: 9g: fix Solaris build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by austin
Modified:
6 years, 3 months ago
Reviewers:
minux
CC:
rsc, minux, golang-codereviews
Visibility:
Public.

Description

liblink: fix Solaris build a->class is a char. Boo hoo.

Patch Set 1 #

Patch Set 2 : diff -r 776e2cb1a1f369115a176a2749909d4a71e0dd64 https://code.google.com/p/go #

Patch Set 3 : diff -r 776e2cb1a1f369115a176a2749909d4a71e0dd64 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/liblink/list6.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
austin
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 branch ...
6 years, 3 months ago (2014-11-14 19:39:04 UTC) #1
minux
LGTM. Shouldn't the description start with "liblink:" instead of always "9g:"?
6 years, 3 months ago (2014-11-14 20:46:56 UTC) #2
austin
Oops. Muscle memory. :) Fixed. On Fri, Nov 14, 2014 at 3:46 PM, minux <minux@golang.org> ...
6 years, 3 months ago (2014-11-14 20:51:53 UTC) #3
austin
6 years, 3 months ago (2014-11-14 20:53:25 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=f57928630b36 ***

[dev.power64] liblink: fix Solaris build

a->class is a char.  Boo hoo.

LGTM=minux
R=rsc, minux
CC=golang-codereviews
https://codereview.appspot.com/169630043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b