Issue 168990043: code review 168990043: x509: exact BitLength in ASN.1 encoding for certificate...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 168990043: code review 168990043: x509: exact BitLength in ASN.1 encoding for certificate... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by Paul van Brouwershaven

Modified:
9 years, 3 months ago

Reviewers:

CC:
agl, golang-codereviews

Visibility:
Public.

Description

x509: exact BitLength in ASN.1 encoding for certificate KeyUsage The encoded value of the certificate KeyUsage did contain additonal padding that was not present with other certificate generators. According to ITU-T X.690 the BitLength value should have no padding in a DER encoding. See discussion: https://groups.google.com/forum/#!topic/golang-nuts/dzaJ3hMpDcs

Patch Set 1 #

Patch Set 2 : diff -r 35193bf04a5b64f361a1f88307188fa2d148566b https://code.google.com/p/go #

Patch Set 3 : diff -r 35193bf04a5b64f361a1f88307188fa2d148566b https://code.google.com/p/go #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/crypto/x509/x509.go	View	1 2	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul van Brouwershaven

Hello agl@chromium.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 5 months ago (2014-11-05 09:35:37 UTC) #1

Paul van Brouwershaven

Hello agl@chromium.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 5 months ago (2014-11-05 10:29:28 UTC) #2

gobot

9 years, 4 months ago (2014-12-19 05:15:30 UTC) #3

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/168990043 is best) in the description in your
new CL.

Thanks very much.

Expand All Messages | Collapse All Messages