Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(31)

Issue 1664050: Change scope of ProxyRenderer#createPipelinedProxyRequest to protected (from private)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by janluehe
Modified:
15 years, 5 months ago
Reviewers:
henry.saputra, chirag, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This would allow subclasses of ProxyRenderer to override "render" without having to duplicate "createPipelinedProxyRequest"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
janluehe
15 years, 8 months ago (2010-07-01 19:38:27 UTC) #1
henry.saputra
LGTM
15 years, 5 months ago (2010-10-11 19:33:20 UTC) #2
chirag
LGTM too
15 years, 5 months ago (2010-10-11 22:49:31 UTC) #3
chirag
15 years, 5 months ago (2010-10-12 04:10:18 UTC) #4
Committed at r1021619. Thank you Jan!

On 2010/10/11 22:49:31, chirag wrote:
> LGTM too
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b