Descriptiongo.crypto/ssh: ensure {Server,Client}Conn do not expose io.ReadWriter
Transport should not be a ReadWriter. It can only write packets, i.e. no partial reads or writes. Furthermore, you can currently do ClientConn.Write() while the connection is live, which sends raw bytes over the connection. Doing so will confuse the transports because the data is not encrypted.
As a consequence, ClientConn and ServerConn stop being a net.Conn
Finally, ensure that {Server,Client}Conn implement LocalAddr and RemoteAddr methods that previously were exposed by an embedded net.Conn field.
Patch Set 1 #Patch Set 2 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 3 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 4 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 5 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 6 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #
Total comments: 1
Patch Set 7 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 8 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #Patch Set 9 : diff -r d11168ee6396 https://code.google.com/p/go.crypto #
MessagesTotal messages: 16
|