Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 165400043: code review 165400043: test: remove failing cases from sinit.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by iant
Modified:
5 years ago
Reviewers:
gobot, rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

test: comment out failing cases from sinit.go One failing case this removes is: var bytes = []byte("hello, world") var copy_bytes = bytes We could handle this in the compiler, but it requires special case for a variable that is initialized to the value of a variable that is initialized to a string literal converted to []byte. This seems an unlikely case--it never occurs in the standrd library--and it seems unnecessary to write the code to handle it. If we do want to support this case, one approach is https://codereview.appspot.com/171840043. The other failing cases are of the form var bx bool var copy_bx = bx The compiler used to initialize copy_bx to false. However, that led to issue 7665, since bx may be initialized in non-Go code. The compiler no longer assumes that bx must be false, so copy_bx can not be statically initialized. We can fix these with https://codereview.appspot.com/169040043 if we also pass -complete to the compiler as part of this test. This is OK but it's too late in the release cycle. Fixes issue 8746.

Patch Set 1 #

Patch Set 2 : diff -r 53ebc70d4e9f843cb718f173e3225e9a0fc121e2 https://code.google.com/p/go #

Patch Set 3 : diff -r 53ebc70d4e9f843cb718f173e3225e9a0fc121e2 https://code.google.com/p/go #

Patch Set 4 : diff -r ac895322f04786e15b483a63d9b19444d68b83fe https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M test/sinit.go View 1 2 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 8
iant
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years ago (2014-11-03 05:07:38 UTC) #1
rsc
Can you comment out the lines instead of deleting them? The test used to work, ...
5 years ago (2014-11-04 15:07:02 UTC) #2
rsc
LGTM otherwise
5 years ago (2014-11-04 15:07:19 UTC) #3
iant
I actually have the changes to make this test cases pass. I don't think they ...
5 years ago (2014-11-04 17:41:47 UTC) #4
rsc
LGTM
5 years ago (2014-11-04 18:00:08 UTC) #5
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=f60b128afd41 *** test: comment out failing cases from sinit.go One failing case ...
5 years ago (2014-11-04 18:20:35 UTC) #6
gobot
This CL appears to have broken the openbsd-amd64-rootbsd builder. See http://build.golang.org/log/fd7be089282afbaf1738d8fe657447efee082c33
5 years ago (2014-11-04 19:56:07 UTC) #7
iant
5 years ago (2014-11-04 20:12:44 UTC) #8
False positive.

Ian
On Nov 4, 2014 11:56 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-amd64-rootbsd builder.
> See http://build.golang.org/log/fd7be089282afbaf1738d8fe657447efee082c33
>
> https://codereview.appspot.com/165400043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b