Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2089)

Issue 1641041: Fix Issue 120: Replace uses of goog-inline-block with goog.ui.INLINE_BLOCK_CLASSNAME (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by hochhaus
Modified:
1 year, 5 months ago
Reviewers:
nnaze
Base URL:
http://closure-library.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added contact email address to AUTHORS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M closure/goog/ui/imagelessbuttonrenderer.js View 2 chunks +2 lines, -1 line 0 comments Download
M closure/goog/ui/style/app/buttonrenderer.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
nnaze
LGTM http://codereview.appspot.com/1641041/diff/1/2 File AUTHORS (right): http://codereview.appspot.com/1641041/diff/1/2#newcode7 AUTHORS:7: SameGoal LLC contact address would be nice if ...
3 years, 10 months ago #1
hochhaus
Added email address. I'm not sure how to interpret the "File AUTHORS (right):" comment. Let ...
3 years, 10 months ago #2
nnaze
On 2010/06/09 21:52:45, ahochhaus wrote: > Added email address. > > I'm not sure how ...
3 years, 10 months ago #3
hochhaus
On Wed, Jun 9, 2010 at 5:04 PM, <nnaze@google.com> wrote: > General format is > ...
3 years, 10 months ago #4
nnaze
Yep. Sorry, didn't notice you'd updated it. Nathan On Wed, Jun 9, 2010 at 3:09 ...
3 years, 10 months ago #5
nnaze
LGTM. I will ingest this.
3 years, 10 months ago #6
hochhaus
3 years, 10 months ago #7
Thanks.

On Wed, Jun 16, 2010 at 1:01 PM,  <nnaze@google.com> wrote:
> LGTM. I will ingest this.
>
>
>
> http://codereview.appspot.com/1641041/show
>



-- 
Andy Hochhaus
President, Technology
SameGoal, L.L.C.
http://samegoal.com/
Phone: 888-SAMEGOAL x902
           888-726-3462 x902
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5