Issue 163520043: Issue 4151: implicitTimeSignatureVisibility->initialTimeSignatureVisibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163520043: Issue 4151: implicitTimeSignatureVisibility->initialTimeSignatureVisibility (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by Trevor Daniels

Modified:
9 years, 5 months ago

Reviewers:
Dan Eble, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 4151: implicitTimeSignatureVisibility->initialTimeSignatureVisibility Change property name Change description Add convert-ly rule Update all language docs

Patch Set 2 : Remove comment re 'implicit' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -87 lines)			Patch
M	Documentation/de/notation/cheatsheet.itely	View		15 chunks	+16 lines, -16 lines	0 comments	Download
M	Documentation/es/notation/cheatsheet.itely	View		15 chunks	+16 lines, -16 lines	0 comments	Download
M	Documentation/fr/notation/cheatsheet.itely	View		15 chunks	+16 lines, -16 lines	0 comments	Download
M	Documentation/ja/notation/cheatsheet.itely	View		15 chunks	+16 lines, -16 lines	0 comments	Download
M	Documentation/music-glossary.tely	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/notation/cheatsheet.itely	View		15 chunks	+16 lines, -16 lines	0 comments	Download
M	lily/time-signature-engraver.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ly/engraver-init.ly	View		1 chunk	+1 line, -1 line	0 comments	Download
M	python/convertrules.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	scm/define-context-properties.scm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Dan Eble

Thanks for changing this. https://codereview.appspot.com/163520043/diff/1/lily/time-signature-engraver.cc File lily/time-signature-engraver.cc (right): https://codereview.appspot.com/163520043/diff/1/lily/time-signature-engraver.cc#newcode84 lily/time-signature-engraver.cc:84: // Todo: "implicit" does not ...

9 years, 5 months ago (2014-10-29 12:37:29 UTC) #2

Trevor Daniels

On 2014/10/29 12:37:29, Dan Eble wrote: > Thanks for changing this. > > https://codereview.appspot.com/163520043/diff/1/lily/time-signature-engraver.cc > ...

9 years, 5 months ago (2014-10-29 13:32:37 UTC) #4

Trevor Daniels

9 years, 5 months ago (2014-11-03 10:57:19 UTC) #5

Message was sent while issue was closed.

Pushed to staging as
3fd5eabae695f90c0cea826bcea33d54a242b01b

Author: Trevor Daniels  2014-10-29 13:26:36

    Issue 4151: implicitTimeSignatureVisibility->initialTimeSignatureVisibility
    
      Change property name
      Change description
      Add convert-ly rule
      Update all language docs

Closing ...

Expand All Messages | Collapse All Messages