Issue 162050043: Make test resilient to any umask and add workarounds for strace 2.8.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 162050043: Make test resilient to any umask and add workarounds for strace 2.8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by M-A

Modified:
10 years, 9 months ago

Reviewers:
vadimsh

CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org

Base URL:
https://code.google.com/p/swarming.client@master

Visibility:
Public.

More Reviews

Description

Make test resilient to any umask and add workarounds for strace 2.8. Disable trace_inputs_smoke_test.py for now because it's broken on strace 2.8 and it's not a priority to fix this short term. isolate_test.py is still known to fail on OSX, that will be addressed later. This CL is primarily made to fix Ubuntu 14.04 users. R=vadimsh@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=aa4fff5822a2f75323c62ee51173da27f829e319

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -88 lines)			Patch
M	tests/isolate_smoke_test.py	View	4 chunks	+4 lines, -8 lines	0 comments	Download
M	tests/isolate_test.py	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	tests/isolated_format_test.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/run_isolated_smoke_test.py	View	12 chunks	+20 lines, -43 lines	0 comments	Download
M	tests/test_utils.py	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	tests/trace_inputs_smoke_test.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/trace_inputs_test.py	View	4 chunks	+30 lines, -0 lines	0 comments	Download
M	trace_inputs.py	View	2 chunks	+42 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

M-A

10 years, 9 months ago (2014-10-24 13:10:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aa4fff5822a2f75323c62ee51173da27f829e319 (presubmit successful).

Expand All Messages | Collapse All Messages