Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1503)

Issue 1618042: UAN Framework project (GSoC)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by socket
Modified:
6 years ago
Reviewers:
lentracy
CC:
ns-3- reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remus test, updated wscript, brief glider mobility class #

Total comments: 2

Patch Set 3 : Seaglider model implementation #

Patch Set 4 : seaglider mobility test, overall update #

Patch Set 5 : run check-style.py #

Patch Set 6 : Added example and helper #

Total comments: 2

Patch Set 7 : AUV mobility classes refactoring #

Patch Set 8 : Energy models for AUVs and micro modem, mobility models update #

Patch Set 9 : waypoint model modification #

Patch Set 10 : AUV helpers and uan-helper modification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -22 lines) Patch
A src/helper/auv-glider-helper.h View 1 chunk +75 lines, -0 lines 0 comments Download
A src/helper/auv-glider-helper.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A src/helper/auv-remus-helper.h View 1 chunk +71 lines, -0 lines 0 comments Download
A src/helper/auv-remus-helper.cc View 1 chunk +83 lines, -0 lines 0 comments Download
M src/helper/uan-helper.h View 4 chunks +25 lines, -13 lines 0 comments Download
M src/helper/uan-helper.cc View 3 chunks +31 lines, -9 lines 0 comments Download
M src/helper/wscript View 6 7 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
socket
http://codereview.appspot.com/1618042/diff/2001/3008 File src/mobility/wscript (right): http://codereview.appspot.com/1618042/diff/2001/3008#newcode26 src/mobility/wscript:26: 'waypoint-helper-mobility-model.cc', This should not have been here, it is ...
11 years, 3 months ago (2010-06-26 09:51:53 UTC) #1
lentracy
A couple minor comments. http://codereview.appspot.com/1618042/diff/17001/18006 File src/mobility/uan-glider-mobility-model.cc (right): http://codereview.appspot.com/1618042/diff/17001/18006#newcode40 src/mobility/uan-glider-mobility-model.cc:40: // .AddAttribute ("Bounds", "Bounds of ...
11 years, 2 months ago (2010-07-13 04:07:39 UTC) #2
socket
11 years, 1 month ago (2010-08-05 12:07:33 UTC) #3
Review moved to http://codereview.appspot.com/1743057


On 2010/07/13 04:07:39, lentracy wrote:
> A couple minor comments.
> 
> http://codereview.appspot.com/1618042/diff/17001/18006
> File src/mobility/uan-glider-mobility-model.cc (right):
> 
> http://codereview.appspot.com/1618042/diff/17001/18006#newcode40
> src/mobility/uan-glider-mobility-model.cc:40: //    .AddAttribute ("Bounds",
> "Bounds of the area to cruise.",
> What is your plan for this attribute?
> 
> http://codereview.appspot.com/1618042/diff/17001/18007
> File src/mobility/uan-remus-mobility-model.cc (right):
> 
> http://codereview.appspot.com/1618042/diff/17001/18007#newcode261
> src/mobility/uan-remus-mobility-model.cc:261:
UanRemusMobilityModel::DoSubmerge
> (double depth)
> Maybe it would be best to pass deltaDepth as the argument here instead of an
> absolute depth.  Another function perhaps useful to the interface would be
> something along the lines of SetDepth or MakeDepth in which an absolute depth
> could be passed between 0 and m_maxDepth.  Just a thought
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b