Issue 16100044: Skip UserProfile_GUID property from SharePoint User profile metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16100044: Skip UserProfile_GUID property from SharePoint User profile metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Tanmay Vartak

Modified:
10 years, 5 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Skip UserProfile_GUID property from SharePoint User profile metadata Code Commit : https://code.google.com/p/plexi/source/detail?r=03937f63b75b63615c6e510536566e9aa7b19dd3&repo=sharepoint

Patch Set 2 : try2 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -14 lines)			Patch
		src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java	View		5 chunks	+17 lines, -14 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Tanmay Vartak

On 2013/10/23 18:36:40, Tanmay Vartak wrote: another broken one :(

10 years, 6 months ago (2013-10-23 18:37:57 UTC) #2

Tanmay Vartak

https://codereview.appspot.com/16100044/diff/70001/test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java File test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java (right): https://codereview.appspot.com/16100044/diff/70001/test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java#newcode70 test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:70: private void populateProfileProperties ( this rename can be part ...

10 years, 6 months ago (2013-10-23 18:40:41 UTC) #4

ejona

10 years, 6 months ago (2013-10-23 19:42:24 UTC) #5

LGTM

https://codereview.appspot.com/16100044/diff/70001/test/com/google/enterprise...
File
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java
(right):

https://codereview.appspot.com/16100044/diff/70001/test/com/google/enterprise...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:70:
private void populateProfileProperties (
On 2013/10/23 18:40:41, Tanmay Vartak wrote:
> this rename can be part of some other CL but it was bugging me for long time

If it's easy for you, splitting it up is nice. But if it will take too much
effort, don't worry about it, because I know you are busy.

Expand All Messages | Collapse All Messages