Handle Ctrl+C more gracefully when uploading files.

Handle Ctrl+C more gracefully when uploading files.

It still doesn't abort instantly (since there's no mechanism to interrupt
ongoing network call). Better than noting. An alternative would be to 'detach'
worker threads without waiting for them to finish, but it seems to be more
dirty.

Also add timing information to logger output.

R=maruel@chromium.org
BUG=

Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=f9e401bab51a7eb0e92ae70aab73c2bcab6d34d7

[vadimsh, 2014-10-15 13:41:25]

ptal

It now receives Ctrl+C, waits for all ongoing network calls to finish (usually
16 threads doing /contains check) and then dies. It still takes several seconds,
but at least it's not hanging forever.

I want to work on https://code.google.com/p/swarming/issues/detail?id=58. This
CL is a way for me to recall the code in isolateserver.py.

[M-A, 2014-10-15 14:03:53]

lgtm

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py
File isolateserver.py (right):

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py#newcode398
isolateserver.py:398: def abort(self):
Is Storage thread-safe? I forgot.

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py#newcode407
isolateserver.py:407: for s in (signal.SIGTERM, signal.SIGINT):
I would have preferred this to be a stand alone (even potentially reusable)
class. That said it's not strictly needed so the current code is fine until
there's at least a second user of the same logic.

(signal.SIGINT, signal.SIGTERM)

https://codereview.appspot.com/158980043/diff/20001/utils/threading_utils.py
File utils/threading_utils.py (right):

https://codereview.appspot.com/158980043/diff/20001/utils/threading_utils.py#...
utils/threading_utils.py:765: # being called (at least on Python 2.7,
http://bugs.python.org/issue8844).
sigh

[vadimsh, 2014-10-15 14:14:54]

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py
File isolateserver.py (right):

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py#newcode398
isolateserver.py:398: def abort(self):
On 2014/10/15 14:03:53, M-A wrote:
> Is Storage thread-safe? I forgot.

Yes, it is. 

I decided not to add a lock just for checking boolean _aborted, since it's not
C++ with complicated memory access semantics.

'if' here is also fine. In worst case the message will be printed twice. Added a
comment.

https://codereview.appspot.com/158980043/diff/20001/isolateserver.py#newcode407
isolateserver.py:407: for s in (signal.SIGTERM, signal.SIGINT):
On 2014/10/15 14:03:53, M-A wrote:
> I would have preferred this to be a stand alone (even potentially reusable)
> class. That said it's not strictly needed so the current code is fine until
> there's at least a second user of the same logic.
> 
> (signal.SIGINT, signal.SIGTERM)

Done.

[vadimsh, 2014-10-15 14:19:42]

Committed patchset #3 (id:40001) manually as
f9e401bab51a7eb0e92ae70aab73c2bcab6d34d7.

[vadimsh, 2014-10-15 14:22:19]

Looks like trace_inputs_smoke_test.py is failing on Trusty (I have it now). Or
may be I forgot to enable something...

======================================================================
ERROR: test_trace (__main__.TraceInputsImport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./trace_inputs_smoke_test.py", line 43, in hook
    return fn(self, *args, **kwargs)
  File "./trace_inputs_smoke_test.py", line 456, in test_trace
    results = self._execute_trace(self.get_child_command(True))
  File "/home/vadimsh/Desktop/swarming/client/trace_inputs.py", line 1483, in
parse_log
    context.on_line(pid, line)
  File "/home/vadimsh/Desktop/swarming/client/trace_inputs.py", line 1259, in
on_line
    self.get_or_set_proc(pid).on_line(line.strip())
  File "/home/vadimsh/Desktop/swarming/client/trace_inputs.py", line 1017, in
on_line
    return handler(match.group(2), match.group(3))
  File "/home/vadimsh/Desktop/swarming/client/trace_inputs.py", line 877, in
hook
    None, None, None)
TracingFailure: Failed to parse stat(0x941e60, {...}) = 0
pid: 13178
line: 33
stat(0x941e60, {...}) = 0