code review 15870044: go.crypto/ssh: in {Server,Client}Conn, read session ID ...

go.crypto/ssh: in {Server,Client}Conn, read session ID from
transport layer.

[hanwen-google, 2013-10-23 06:28:50]

Hello agl1, dfc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[hanwen-google, 2013-10-23 06:42:08]

this is a break out of  14494058. Once the rekeying is handled at a lower layer,
we don't have kexResult in client.go/server.go, so we should get it from
transport.sessionID

[dave_cheney.net, 2013-10-23 16:00:48]

On 2013/10/23 06:42:08, hanwen-google wrote:
> this is a break out of  14494058. Once the rekeying is handled at a lower
layer,
> we don't have kexResult in client.go/server.go, so we should get it from
> transport.sessionID

Thanks for splitting this out. 

This CL needs a better title, how about 

"go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to authenticate"

+agl, I'd like you to review this please.

[hanwen-google, 2013-10-23 17:44:02]

Changed to " in {Server,Client}Conn, read session ID from
transport layer." (I try to avoid saying what we don't do in descriptions.)

On Wed, Oct 23, 2013 at 9:00 AM,  <dave@cheney.net> wrote:
> On 2013/10/23 06:42:08, hanwen-google wrote:
>>
>> this is a break out of  14494058. Once the rekeying is handled at a
>
> lower layer,
>>
>> we don't have kexResult in client.go/server.go, so we should get it
>
> from
>>
>> transport.sessionID
>
>
> Thanks for splitting this out.
>
> This CL needs a better title, how about
>
> "go.crypto/ssh: {Server,Client}Conn, do not pass sessionID to
> authenticate"
>
> +agl, I'd like you to review this please.
>
> https://codereview.appspot.com/15870044/



-- 
Han-Wen Nienhuys
Google Munich
hanwen@google.com

[agl1, 2013-10-25 15:15:46]

*** Submitted as
https://code.google.com/p/go/source/detail?r=be3d052402de&repo=crypto ***

go.crypto/ssh: in {Server,Client}Conn, read session ID from
transport layer.

R=agl, dave
CC=golang-dev
https://codereview.appspot.com/15870044

Committer: Adam Langley <agl@golang.org>