Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 15870044: code review 15870044: go.crypto/ssh: in {Server,Client}Conn, read session ID ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by hanwen-google
Modified:
5 years, 10 months ago
Reviewers:
CC:
agl1, dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: in {Server,Client}Conn, read session ID from transport layer.

Patch Set 1 #

Patch Set 2 : diff -r e3c12cab1b35 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r e3c12cab1b35 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 213a06a7ce81 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ssh/client.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ssh/client_auth.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ssh/server.go View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
hanwen-google
Hello agl1, dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 11 months ago (2013-10-23 06:28:50 UTC) #1
hanwen-google
this is a break out of 14494058. Once the rekeying is handled at a lower ...
5 years, 11 months ago (2013-10-23 06:42:08 UTC) #2
dfc
On 2013/10/23 06:42:08, hanwen-google wrote: > this is a break out of 14494058. Once the ...
5 years, 11 months ago (2013-10-23 16:00:48 UTC) #3
hanwen-google
Changed to " in {Server,Client}Conn, read session ID from transport layer." (I try to avoid ...
5 years, 11 months ago (2013-10-23 17:44:02 UTC) #4
agl1
5 years, 10 months ago (2013-10-25 15:15:46 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=be3d052402de&repo=crypto ***

go.crypto/ssh: in {Server,Client}Conn, read session ID from
transport layer.

R=agl, dave
CC=golang-dev
https://codereview.appspot.com/15870044

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b