Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 15850044: Improvements to \offset

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by david.nalesnik
Modified:
10 years, 5 months ago
Reviewers:
janek, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Improvements to \offset Property can be specified with or without #' prefix. Directed tweaks are possible. Regtest: --remove #' prefix before property names --remove unnecessary # before numbers --add example showing directed tweaks Revise docstring of find-value-to-offset in `scm/music-functions.scm.'

Patch Set 1 #

Patch Set 2 : re-upload #

Total comments: 1

Patch Set 3 : Return tweaked music with failed tweak #

Patch Set 4 : fix faulty tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -26 lines) Patch
M input/regression/offsets.ly View 1 2 3 3 chunks +22 lines, -13 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 1 chunk +33 lines, -11 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8
david.nalesnik
Please review.
10 years, 5 months ago (2013-10-22 14:26:10 UTC) #1
david.nalesnik
On 2013/10/22 14:26:10, david.nalesnik wrote: > Please review. Unfortunately, I'm getting the old chunk mismatch ...
10 years, 5 months ago (2013-10-22 14:27:28 UTC) #2
david.nalesnik
On 2013/10/22 14:27:28, david.nalesnik wrote: > On 2013/10/22 14:26:10, david.nalesnik wrote: > > Please review. ...
10 years, 5 months ago (2013-10-23 12:22:25 UTC) #3
david.nalesnik
https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722 ly/music-functions-init.ly:722: (make-music 'Music))) Hmm... Shouldn't the return here be `item' ...
10 years, 5 months ago (2013-10-23 14:24:33 UTC) #4
dak
On 2013/10/23 14:24:33, david.nalesnik wrote: > https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly > File ly/music-functions-init.ly (right): > > https://codereview.appspot.com/15850044/diff/120001/ly/music-functions-init.ly#newcode722 > ...
10 years, 5 months ago (2013-10-23 14:30:42 UTC) #5
dak
On 2013/10/23 14:30:42, dak wrote: > > The way the code is now, the snippet ...
10 years, 5 months ago (2013-10-23 14:36:41 UTC) #6
david.nalesnik
On 2013/10/23 14:36:41, dak wrote: > Fixing the proposal should be all the action > ...
10 years, 5 months ago (2013-10-23 14:40:15 UTC) #7
janek
10 years, 5 months ago (2013-10-23 20:16:06 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b