Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(343)

Issue 156950045: code review 156950045: goprotobuf: Generate JSON marshal/unmarshal methods for... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dsymonds
Modified:
11 years, 1 month ago
Reviewers:
gmlewis1
CC:
gmlewis1, golang-codereviews
Visibility:
Public.

Description

goprotobuf: Generate JSON marshal/unmarshal methods for MessageSet. This only implements marshaling. Unmarshaling is much fiddlier, and it's not even clear that people care about that, so I'm punting it to a later date.

Patch Set 1 #

Patch Set 2 : diff -r 4310c3969b2993dfc5fdf4e5f70f958dbdb20e35 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 4310c3969b2993dfc5fdf4e5f70f958dbdb20e35 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 4310c3969b2993dfc5fdf4e5f70f958dbdb20e35 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -3 lines) Patch
M proto/message_set.go View 1 3 chunks +61 lines, -3 lines 0 comments Download
M protoc-gen-go/generator/generator.go View 1 3 chunks +21 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello gmlewis@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
11 years, 1 month ago (2014-10-12 05:32:15 UTC) #1
gmlewis1
LGTM
11 years, 1 month ago (2014-10-12 05:34:31 UTC) #2
dsymonds
11 years, 1 month ago (2014-10-12 05:35:19 UTC) #3
*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=f123757c0387 ***

goprotobuf: Generate JSON marshal/unmarshal methods for MessageSet.

This only implements marshaling. Unmarshaling is much fiddlier,
and it's not even clear that people care about that, so I'm punting
it to a later date.

LGTM=gmlewis
R=gmlewis
CC=golang-codereviews
https://codereview.appspot.com/156950045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b