Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5009)

Issue 15540045: code review 15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 5 months ago
Reviewers:
khr
CC:
khr
Visibility:
Public.

Description

cmd/6g, cmd/8g, cmd/gc: support for Native Client See golang.org/s/go13nacl for design overview. This CL is publicly visible but not CC'ed to golang-dev, to avoid distracting from the preparation of the Go 1.2 release. This CL and the others will be checked into my rsc-go13nacl clone repo for now, and I will send CLs against the main repo early in the Go 1.3 development.

Patch Set 1 #

Patch Set 2 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 3 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 4 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 5 : diff -r 6752a7aad603 https://code.google.com/r/rsc-go13nacl #

Patch Set 6 : diff -r eca0ca43a863 https://code.google.com/r/rsc-go13nacl #

Patch Set 7 : diff -r de159d1f10be https://code.google.com/r/rsc-go13nacl #

Total comments: 2

Patch Set 8 : diff -r 79958c5728b9 https://code.google.com/r/rsc-go13nacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -51 lines) Patch
M src/cmd/5g/galign.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/cgen.c View 1 2 chunks +9 lines, -9 lines 0 comments Download
M src/cmd/6g/galign.c View 1 2 3 4 5 2 chunks +20 lines, -0 lines 0 comments Download
M src/cmd/6g/gg.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/cmd/6g/ggen.c View 1 2 3 4 5 8 chunks +39 lines, -21 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 6 chunks +32 lines, -5 lines 0 comments Download
M src/cmd/6g/prog.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6g/reg.c View 1 4 chunks +3 lines, -4 lines 0 comments Download
M src/cmd/8g/galign.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8g/gg.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8g/ggen.c View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/gc/align.c View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/gc/builtin.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M src/cmd/gc/obj.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/pgen.c View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/gc/reflect.c View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/gc/runtime.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/walk.c View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
khr
LGTM. https://codereview.appspot.com/15540045/diff/170001/src/cmd/6g/ggen.c File src/cmd/6g/ggen.c (right): https://codereview.appspot.com/15540045/diff/170001/src/cmd/6g/ggen.c#newcode1065 src/cmd/6g/ggen.c:1065: gconreg(AMOVL, 0, D_AX); Why does this matter?
10 years, 5 months ago (2013-11-07 22:20:57 UTC) #1
rsc
thanks https://codereview.appspot.com/15540045/diff/170001/src/cmd/6g/ggen.c File src/cmd/6g/ggen.c (right): https://codereview.appspot.com/15540045/diff/170001/src/cmd/6g/ggen.c#newcode1065 src/cmd/6g/ggen.c:1065: gconreg(AMOVL, 0, D_AX); On 2013/11/07 22:20:57, khr wrote: ...
10 years, 5 months ago (2013-11-08 00:39:47 UTC) #2
rsc
Hello khr@golang.org, I'd like you to review this change to https://code.google.com/r/rsc-go13nacl
10 years, 5 months ago (2013-11-11 14:48:17 UTC) #3
rsc
10 years, 5 months ago (2013-11-11 14:48:25 UTC) #4
*** Submitted as fb56d5bbe068 ***

cmd/6g, cmd/8g, cmd/gc: support for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R=khr
https://codereview.appspot.com/15540045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b