Issue 4152: Eliminate "will never be null" warnings in smobs.tcc

Issue 4152: Eliminate "will never be null" warnings in smobs.tcc

Hopefully this will no longer cause spurious warnings with g++ 4.7.

[Dan Eble, 2014-10-04 13:19:35]

Not using different types for members with the same name is an improvement.
This works with gcc 4.4.3 in LilyDev.

https://codereview.appspot.com/153970044/diff/1/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/153970044/diff/1/lily/include/smobs.hh#newcode175
lily/include/smobs.hh:175: // Since we consider those internal-only, two of them
are actually
Update comment?

[dak, 2014-10-04 14:08:13]

https://codereview.appspot.com/153970044/diff/1/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/153970044/diff/1/lily/include/smobs.hh#newcode175
lily/include/smobs.hh:175: // Since we consider those internal-only, two of them
are actually
On 2014/10/04 13:19:35, Dan Eble wrote:
> Update comment?

Acknowledged.

[dak, 2014-10-04 14:36:41]

Fixed comment flagged by Dan and some more

[Dan Eble, 2014-10-04 15:19:56]

https://codereview.appspot.com/153970044/diff/20001/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/153970044/diff/20001/lily/include/smobs.hh#new...
lily/include/smobs.hh:145: template <class Super>
FWIW, "Super" confused me mightily until I saw by the light of day that it
refers to the derived class.

[dak, 2014-10-04 15:34:57]

https://codereview.appspot.com/153970044/diff/20001/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/153970044/diff/20001/lily/include/smobs.hh#new...
lily/include/smobs.hh:145: template <class Super>
On 2014/10/04 15:19:56, Dan Eble wrote:
> FWIW, "Super" confused me mightily until I saw by the light of day that it
> refers to the derived class.

Well, it is not just "the derived class" since several classes derive from
Smob_base.  It the "ultimately" derived class that is being managed by the
Smob_base<Super> specialization.

If you feel you can put in something useful, feel free to go ahead.  In my
defense, the templated code is easier to get the hang of than the previous macro
preprocessor code if I may say so.  And I wrote almost all the documentation for
the previous macro preprocessor code.  Without being responsible for the macro
preprocessor code itself, I may mention.

With an ominous voice and unsteadily flickering eyes.  Just saying.

[Dan Eble, 2014-10-04 16:55:59]

On 2014/10/04 15:34:57, dak wrote:
> With an ominous voice and unsteadily flickering eyes.  Just saying.

:)