Issue 153970043: Eliminate "will never be null" warnings in smobs.tcc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153970043: Eliminate "will never be null" warnings in smobs.tcc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by Dan Eble

Modified:
9 years, 6 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Eliminate "will never be null" warnings in smobs.tcc.

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
	M	lily/include/smobs.tcc	View		2 chunks	+41 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

9 years, 6 months ago (2014-10-04 04:32:43 UTC) #2

On 2014/10/04 04:12:14, Dan Eble wrote:
> It's verbose, but it does the trick portably (I think).

Too clever.  I don't want to obfuscate the code like that (bringing type
overloading into play) just to dance around a warning.  print_smob does not need
a check: we'll always set something other than the default print routine.  The
other checks are going the way of mark_smob: just create a do-nothing default
function, and don't bother installing it when it has not been overridden.

I went through that dear-compiler-are-you-serious dance when turning mark_smob
into a member function (incidentally, that's what print_smob is going to do as
well).  No point in doing the others in a different manner.

Expand All Messages | Collapse All Messages