Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

Issue 152048: code review 152048: net: fix dns bug reported on irc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by rsc
Modified:
10 years, 2 months ago
Reviewers:
agl1, agl
CC:
golang-dev
Visibility:
Public.

Description

net: fix dns bug reported on irc. if suffixes don't work, check for name directly. also fixes short names like bit.ly when ndots>1. tested by tossing domain and search lines from /etc/resolv.conf Fixes issue 2.

Patch Set 1 #

Patch Set 2 : code review 152048: net: fix dns bug reported on irc. #

Patch Set 3 : code review 152048: net: fix dns bug reported on irc. #

Patch Set 4 : code review 152048: net: fix dns bug reported on irc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/pkg/net/dnsclient.go View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/net/net_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
agl1
LGTM. You might want "Fixes issue 2" or BUG=2 or something in the description.
10 years, 2 months ago (2009-11-11 01:04:18 UTC) #1
rsc
Hello agl, agl1 (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
10 years, 2 months ago (2009-11-11 01:04:23 UTC) #2
rsc
10 years, 2 months ago (2009-11-11 01:09:35 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=de1a91a5a801 ***

net: fix dns bug reported on irc.

if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.

tested by tossing domain and search lines from /etc/resolv.conf

Fixes issue 2.

R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/152048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b