Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2764)

Issue 151230044: Roman numerals may be used for page numbers too (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by Valentin Villenave
Modified:
9 years, 6 months ago
Reviewers:
Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Roman numerals may be used for page numbers too This patch set builds on the number-format function used for string numbers (see #145490043, yet to be LGTMed) and enables it for page numbers, through a new 'page-number-type paper property. Previously, a custom markup function had to be used as demonstrated in the bookparts.ly regtest, which has now been rewritten to make use of the new property.

Patch Set 1 #

Patch Set 2 : Minor coding style correction #

Patch Set 3 : Rebase onto staging #

Total comments: 2

Patch Set 4 : Doc consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M input/regression/bookparts.ly View 2 chunks +11 lines, -6 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M scm/titling.scm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
Valentin Villenave
Minor coding style correction
9 years, 6 months ago (2014-10-09 11:45:30 UTC) #1
Valentin Villenave
Rebase onto staging
9 years, 6 months ago (2014-10-09 12:05:00 UTC) #2
Valentin Villenave
Greetings, having pushed the recent "string-number-styles" patch, I thought another area where we might benefit ...
9 years, 6 months ago (2014-10-09 12:09:14 UTC) #3
Trevor Daniels
LGTM, Valentin, apart from a trivial nit-pick. Trevor https://codereview.appspot.com/151230044/diff/40001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/151230044/diff/40001/Documentation/notation/spacing.itely#newcode1000 Documentation/notation/spacing.itely:1000: Default: ...
9 years, 6 months ago (2014-10-12 09:56:55 UTC) #4
Valentin Villenave
Thanks Trevor. https://codereview.appspot.com/151230044/diff/40001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/151230044/diff/40001/Documentation/notation/spacing.itely#newcode1000 Documentation/notation/spacing.itely:1000: Default: @code{#'arabic}. On 2014/10/12 09:56:55, Trevor Daniels ...
9 years, 6 months ago (2014-10-12 10:59:19 UTC) #5
Valentin Villenave
9 years, 6 months ago (2014-10-12 11:00:58 UTC) #6
Doc consistency
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b