Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13285)

Issue 150670043: Add original-breaks.ly commands

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by uliska
Modified:
9 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add original-breaks.ly commands The commands defined in this patch allow the user to insert breaks (line and page) from the original manuscript that are conditionally respected or discarded. This is very useful for entering and proof-reading music from larger scores. Actually I would prefer having them enabled automatically (i.e. parsed on initialisation without requiring to include the file explicitly. But I think the way it is done in the patch will make it easier to accept its inclusion. Two commits: Add docs for original-breaks.ly Add original-breaks.ly Define commands: - origBreak - origPageBreak Depending on the presence and state of variables - keep-original-breaks - keep-original-page-breaks these result in a \break or \pageBreak or nothing. Default is #t (so when the file is included original breaks are automatically respected). Additionally define top-level commands - \keepOriginalBreaks - \discardOriginalBreaks - \keepOriginalPageBreaks - \discardOriginalPageBreaks The idea is to let the user enter breaks from the manuscript she is copying. While working on the content of the score it is very handy to have LilyPond compile the score with the breaks of the original manuscript, but of course one doesn't want to enter hard-coded breaks.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -0 lines) Patch
M Documentation/notation/spacing.itely View 2 chunks +79 lines, -0 lines 3 comments Download
A ly/original-breaks.ly View 1 chunk +69 lines, -0 lines 1 comment Download

Messages

Total messages: 10
uliska
9 years, 6 months ago (2014-10-07 08:37:06 UTC) #1
Dan Eble
On 2014/10/07 08:37:06, uliska wrote: On 2014/10/07 08:37:06, uliska wrote: On 2014/10/07 08:37:06, uliska wrote: ...
9 years, 6 months ago (2014-10-07 22:30:53 UTC) #2
dak
On 2014/10/07 22:30:53, Dan Eble wrote: > * When using original breaks, wouldn't one also ...
9 years, 6 months ago (2014-10-08 03:24:58 UTC) #3
Keith
For this particular task, you should also show the user that he can define at ...
9 years, 6 months ago (2014-10-08 05:01:40 UTC) #4
uliska
https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacing.itely#newcode1857 Documentation/notation/spacing.itely:1857: @end lilypond On 2014/10/08 05:01:40, Keith wrote: > Why ...
9 years, 6 months ago (2014-10-09 08:11:29 UTC) #5
Trevor Daniels
I've not followed the corresponding email discussion closely, and maybe I've missed something, but how ...
9 years, 6 months ago (2014-10-09 10:21:45 UTC) #6
Graham Percival
On Thu, Oct 09, 2014 at 10:21:45AM +0000, tdanielsmusic@googlemail.com wrote: > I've not followed the ...
9 years, 6 months ago (2014-10-09 10:41:36 UTC) #7
dak
On 2014/10/09 10:21:45, Trevor Daniels wrote: > It would also be trivial to remove all ...
9 years, 6 months ago (2014-10-09 10:44:07 UTC) #8
fedelogy
2014-10-09 12:41 GMT+02:00 Graham Percival <graham@percival-music.ca>: > On Thu, Oct 09, 2014 at 10:21:45AM +0000, ...
9 years, 6 months ago (2014-10-09 21:44:32 UTC) #9
Keith
9 years, 6 months ago (2014-10-10 04:36:14 UTC) #10
On 2014/10/09 08:11:29, uliska wrote:
> On 2014/10/08 05:01:40, Keith wrote:
> > Why not store the common music in a variable, and show
> >  \score {\music}
> >  \discaredOriginalBreaks
> >  \score {\music}
> > ?
> 
> Because it wouldn't work that way. \discardOriginalBreaks 
> would be interpreted when the command is written. 

Oh.  I see how it works now.

https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):

https://codereview.appspot.com/150670043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:1842: \discardOriginalBreaks
In that case you could do everything you describe in this documentation by
typing
  origBreak = {} %\break
here instead of \discardOriginalBreaks, and then we don't need the include file.

Do you plan to add a command-line option like -doriginal-breaks so you can
switch behaviors from the command line?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b