Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(993)

Issue 150170043: [plaso] Made preprocessing artifact driven #155

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Joachim Metz
Modified:
2 weeks, 5 days ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren, romaing
Visibility:
Public.

Description

[plaso] Made preprocessing artifact driven #155 Dependent on: * artifacts update * plaso https://codereview.appspot.com/326740043/

Patch Set 1 #

Total comments: 28

Patch Set 2 : Worked on artifact based preprocessor support #

Total comments: 40

Patch Set 3 : Changes after merge #

Patch Set 4 : Changes after review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1323 lines, -950 lines) Patch
M config/dpkg/control View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dependencies.ini View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/analysis/definitions.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plaso/cli/helpers/artifact_definitions.py View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M plaso/cli/log2timeline_tool.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M plaso/cli/psort_tool.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M plaso/cli/psteal_tool.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M plaso/dependencies.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/engine/engine.py View 1 2 chunks +5 lines, -2 lines 0 comments Download
M plaso/frontend/image_export.py View 1 2 chunks +10 lines, -1 line 0 comments Download
M plaso/preprocessors/__init__.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/preprocessors/interface.py View 1 2 3 2 chunks +226 lines, -157 lines 1 comment Download
M plaso/preprocessors/linux.py View 1 2 3 4 chunks +65 lines, -36 lines 0 comments Download
A + plaso/preprocessors/macos.py View 1 2 3 8 chunks +163 lines, -159 lines 0 comments Download
M plaso/preprocessors/manager.py View 1 2 3 4 chunks +103 lines, -57 lines 0 comments Download
M plaso/preprocessors/windows.py View 1 2 3 8 chunks +211 lines, -105 lines 1 comment Download
M requirements.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M setup.cfg View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test_data/artifacts/artifacts.yaml View 1 2 chunks +198 lines, -7 lines 0 comments Download
M tests/engine/engine.py View 1 2 chunks +10 lines, -2 lines 0 comments Download
M tests/engine/single_process.py View 1 3 chunks +9 lines, -1 line 0 comments Download
M tests/multi_processing/task_engine.py View 1 3 chunks +8 lines, -1 line 0 comments Download
M tests/preprocessors/linux.py View 1 2 3 1 chunk +34 lines, -34 lines 0 comments Download
A + tests/preprocessors/macos.py View 1 2 3 5 chunks +75 lines, -76 lines 0 comments Download
D tests/preprocessors/macosx.py View 1 1 chunk +0 lines, -177 lines 0 comments Download
M tests/preprocessors/manager.py View 1 2 3 1 chunk +38 lines, -46 lines 0 comments Download
M tests/preprocessors/test_lib.py View 1 2 3 5 chunks +47 lines, -19 lines 0 comments Download
M tests/preprocessors/windows.py View 1 2 3 6 chunks +94 lines, -56 lines 0 comments Download

Messages

Total messages: 20
Joachim Metz
2 years, 9 months ago (2014-09-27 09:14:38 UTC) #1
Joachim Metz
Very early state of the CL, put this out there for discussion purposes.
2 years, 9 months ago (2014-09-27 09:15:57 UTC) #2
kiddi
I've got few comments here, let's just send them away so that you at least ...
2 years, 7 months ago (2014-11-04 05:28:33 UTC) #3
Joachim Metz
Merging with work on stand-alone artifact definition Python module: https://github.com/joachimmetz/artifacts
2 years, 7 months ago (2014-11-23 09:29:33 UTC) #4
kiddi
What is the current status of this? Are we hoping to push this in before ...
2 years, 6 months ago (2014-12-13 03:37:01 UTC) #5
Joachim Metz
After On Sat, Dec 13, 2014 at 4:37 AM, <kiddi@kiddaland.net> wrote: > > What is ...
2 years, 6 months ago (2014-12-13 07:28:44 UTC) #6
onager
1 year, 2 months ago (2016-04-05 08:20:35 UTC) #7
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-04-09 13:53:50 UTC) #8
Joachim Metz
Code updated.
1 month, 1 week ago (2017-05-14 06:17:02 UTC) #9
Joachim Metz
Code updated.
1 month, 1 week ago (2017-05-14 06:41:54 UTC) #10
Joachim Metz
https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows.yaml File data/artifacts/windows.yaml (right): https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows.yaml#newcode12 data/artifacts/windows.yaml:12: supported_os: [Windows] not necessary https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows_paths.yaml File data/artifacts/windows_paths.yaml (right): https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows_paths.yaml#newcode24 ...
1 month ago (2017-05-20 17:43:09 UTC) #11
Joachim Metz
Code updated.
1 month ago (2017-05-20 19:25:53 UTC) #12
Joachim Metz
Code updated.
1 month ago (2017-05-21 19:35:12 UTC) #13
Joachim Metz
PTAL
1 month ago (2017-05-22 17:48:34 UTC) #14
onager
https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py File plaso/cli/helpers/artifact_definitions.py (right): https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py#newcode59 plaso/cli/helpers/artifact_definitions.py:59: data_location = getattr(configuration_object, u'_data_location', None) Why is this a ...
3 weeks, 2 days ago (2017-06-01 02:38:19 UTC) #15
Joachim Metz
Code updated.
2 weeks, 6 days ago (2017-06-04 05:34:49 UTC) #16
Joachim Metz
Code updated.
2 weeks, 6 days ago (2017-06-04 06:08:12 UTC) #17
Joachim Metz
https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py File plaso/cli/helpers/artifact_definitions.py (right): https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py#newcode59 plaso/cli/helpers/artifact_definitions.py:59: data_location = getattr(configuration_object, u'_data_location', None) leaving as-is for now, ...
2 weeks, 6 days ago (2017-06-04 06:30:32 UTC) #18
Joachim Metz
Code updated.
2 weeks, 6 days ago (2017-06-04 08:36:02 UTC) #19
onager
2 weeks, 5 days ago (2017-06-05 05:53:01 UTC) #20
LGTM - two minor comments

https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/inte...
File plaso/preprocessors/interface.py (right):

https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/inte...
plaso/preprocessors/interface.py:250: # CurrentControl set so we correct it here
for now.
CurrentControlSet

https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/wind...
File plaso/preprocessors/windows.py (right):

https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/wind...
plaso/preprocessors/windows.py:126: u'Unsupported artifact: {0:s} value type:
{1:s}.'.format(
This (and the similar exception above) is still unclear to me. The problem is
that the data for an attribute is an unexpected type, correct? The artifact
itself is supported, but the type is unexpected. 

Please reword both this exception message, and the other, similar ones.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted