Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 150170043: [plaso] Made preprocessing artifact driven #155 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Joachim Metz
Modified:
3 weeks, 3 days ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren, romaing
Visibility:
Public.

Description

[plaso] Made preprocessing artifact driven #155 Dependent on: * plaso https://codereview.appspot.com/326740043/

Patch Set 1 #

Total comments: 28

Patch Set 2 : Worked on artifact based preprocessor support #

Total comments: 40

Patch Set 3 : Changes after review #

Total comments: 4

Patch Set 4 : Changes after review and merge #

Patch Set 5 : Changes after review and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1382 lines, -1315 lines) Patch
M config/dpkg/control View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M dependencies.ini View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/analysis/definitions.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M plaso/cli/helpers/artifact_definitions.py View 1 2 3 3 chunks +27 lines, -11 lines 0 comments Download
M plaso/cli/log2timeline_tool.py View 1 2 3 4 5 chunks +8 lines, -4 lines 0 comments Download
M plaso/cli/psort_tool.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M plaso/cli/psteal_tool.py View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M plaso/dependencies.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/engine/engine.py View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M plaso/frontend/image_export.py View 1 2 chunks +10 lines, -1 line 0 comments Download
M plaso/preprocessors/__init__.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/preprocessors/interface.py View 1 2 3 2 chunks +226 lines, -157 lines 0 comments Download
M plaso/preprocessors/linux.py View 1 2 4 chunks +65 lines, -36 lines 0 comments Download
A + plaso/preprocessors/macos.py View 1 2 3 4 8 chunks +163 lines, -159 lines 0 comments Download
D plaso/preprocessors/macosx.py View 1 3 4 1 chunk +0 lines, -349 lines 0 comments Download
M plaso/preprocessors/manager.py View 1 2 3 4 chunks +114 lines, -57 lines 0 comments Download
M plaso/preprocessors/windows.py View 1 2 3 8 chunks +217 lines, -105 lines 0 comments Download
M requirements.txt View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M setup.cfg View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M test_data/artifacts/artifacts.yaml View 1 2 chunks +198 lines, -7 lines 0 comments Download
M tests/cli/extraction_tool.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/cli/log2timeline_tool.py View 1 2 3 4 9 chunks +13 lines, -0 lines 0 comments Download
M tests/cli/status_view.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/engine/engine.py View 1 2 chunks +10 lines, -2 lines 0 comments Download
M tests/engine/single_process.py View 1 3 chunks +9 lines, -1 line 0 comments Download
M tests/multi_processing/task_engine.py View 1 3 chunks +8 lines, -1 line 0 comments Download
M tests/preprocessors/linux.py View 1 2 1 chunk +34 lines, -34 lines 0 comments Download
A + tests/preprocessors/macos.py View 1 2 5 chunks +75 lines, -76 lines 0 comments Download
D tests/preprocessors/macosx.py View 1 1 chunk +0 lines, -177 lines 0 comments Download
M tests/preprocessors/manager.py View 1 2 3 1 chunk +39 lines, -46 lines 0 comments Download
M tests/preprocessors/test_lib.py View 1 2 5 chunks +47 lines, -19 lines 0 comments Download
M tests/preprocessors/windows.py View 1 2 6 chunks +94 lines, -56 lines 0 comments Download

Messages

Total messages: 27
Joachim Metz
2 years, 10 months ago (2014-09-27 09:14:38 UTC) #1
Joachim Metz
Very early state of the CL, put this out there for discussion purposes.
2 years, 10 months ago (2014-09-27 09:15:57 UTC) #2
kiddi
I've got few comments here, let's just send them away so that you at least ...
2 years, 9 months ago (2014-11-04 05:28:33 UTC) #3
Joachim Metz
Merging with work on stand-alone artifact definition Python module: https://github.com/joachimmetz/artifacts
2 years, 9 months ago (2014-11-23 09:29:33 UTC) #4
kiddi
What is the current status of this? Are we hoping to push this in before ...
2 years, 8 months ago (2014-12-13 03:37:01 UTC) #5
Joachim Metz
After On Sat, Dec 13, 2014 at 4:37 AM, <kiddi@kiddaland.net> wrote: > > What is ...
2 years, 8 months ago (2014-12-13 07:28:44 UTC) #6
onager
1 year, 4 months ago (2016-04-05 08:20:35 UTC) #7
Joachim Metz
Code updated.
4 months, 1 week ago (2017-04-09 13:53:50 UTC) #8
Joachim Metz
Code updated.
3 months, 1 week ago (2017-05-14 06:17:02 UTC) #9
Joachim Metz
Code updated.
3 months, 1 week ago (2017-05-14 06:41:54 UTC) #10
Joachim Metz
https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows.yaml File data/artifacts/windows.yaml (right): https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows.yaml#newcode12 data/artifacts/windows.yaml:12: supported_os: [Windows] not necessary https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows_paths.yaml File data/artifacts/windows_paths.yaml (right): https://codereview.appspot.com/150170043/diff/1/data/artifacts/windows_paths.yaml#newcode24 ...
3 months ago (2017-05-20 17:43:09 UTC) #11
Joachim Metz
Code updated.
3 months ago (2017-05-20 19:25:53 UTC) #12
Joachim Metz
Code updated.
3 months ago (2017-05-21 19:35:12 UTC) #13
Joachim Metz
PTAL
2 months, 4 weeks ago (2017-05-22 17:48:34 UTC) #14
onager
https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py File plaso/cli/helpers/artifact_definitions.py (right): https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py#newcode59 plaso/cli/helpers/artifact_definitions.py:59: data_location = getattr(configuration_object, u'_data_location', None) Why is this a ...
2 months, 2 weeks ago (2017-06-01 02:38:19 UTC) #15
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-06-04 05:34:49 UTC) #16
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-06-04 06:08:12 UTC) #17
Joachim Metz
https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py File plaso/cli/helpers/artifact_definitions.py (right): https://codereview.appspot.com/150170043/diff/120001/plaso/cli/helpers/artifact_definitions.py#newcode59 plaso/cli/helpers/artifact_definitions.py:59: data_location = getattr(configuration_object, u'_data_location', None) leaving as-is for now, ...
2 months, 2 weeks ago (2017-06-04 06:30:32 UTC) #18
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-06-04 08:36:02 UTC) #19
onager
LGTM - two minor comments https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/interface.py File plaso/preprocessors/interface.py (right): https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/interface.py#newcode250 plaso/preprocessors/interface.py:250: # CurrentControl set so ...
2 months, 2 weeks ago (2017-06-05 05:53:01 UTC) #20
Joachim Metz
Code updated.
1 month, 2 weeks ago (2017-07-02 07:08:52 UTC) #21
Joachim Metz
https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/interface.py File plaso/preprocessors/interface.py (right): https://codereview.appspot.com/150170043/diff/180001/plaso/preprocessors/interface.py#newcode250 plaso/preprocessors/interface.py:250: # CurrentControl set so we correct it here for ...
1 month, 2 weeks ago (2017-07-02 07:15:29 UTC) #22
Joachim Metz
Code updated.
1 month, 2 weeks ago (2017-07-02 07:17:50 UTC) #23
Joachim Metz
Code updated.
1 month, 2 weeks ago (2017-07-02 08:39:16 UTC) #24
Joachim Metz
Code updated.
1 month, 2 weeks ago (2017-07-02 09:39:22 UTC) #25
Joachim Metz
Code updated.
1 month, 1 week ago (2017-07-08 17:28:30 UTC) #26
Joachim Metz
3 weeks, 3 days ago (2017-07-27 06:41:04 UTC) #27
merged via github due to pylint 1.7 linting conflicts
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted