Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(417)

Issue 150044: Tracker 836: Add facility to change output file-name for a \book block (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by Ian Hulin
Modified:
9 years, 7 months ago
Reviewers:
carl.d.sorensen, Neil Puttock
CC:
lilypond-devel_gnu.org, frogs_lilynet.net, lilypnd-devel_gnu.org
Visibility:
Public.

Description

Tracker 836: Add facility to change output file-name for a \book block or to set a suffix to prevent multiple files over-writing each other during a compilation. This change allows user to do this via functions rather than having to do so by using set! and define on parser variables in Scheme.

Patch Set 1 #

Total comments: 11

Patch Set 2 : Tidy up pitched-trill in music-functions-init and fix trailing spaces in lily-library #

Patch Set 3 : Remove trailing spaces in parser.yy #

Total comments: 13

Patch Set 4 : Sort out spaces+tabs whitespace problems in music-functions-init.ly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -52 lines) Patch
M lily/parser.yy View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M ly/init.ly View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 chunks +40 lines, -32 lines 0 comments Download
M scm/lily-library.scm View 1 1 chunk +41 lines, -15 lines 0 comments Download

Messages

Total messages: 10
Ian Hulin
The latest version of this patch is now ready for review. Cheers, Ian
9 years, 7 months ago (2009-11-08 20:17:37 UTC) #1
Neil Puttock
On 2009/11/08 20:17:37, Ian Hulin wrote: > The latest version of this patch is now ...
9 years, 7 months ago (2009-11-08 21:39:45 UTC) #2
Neil Puttock
http://codereview.appspot.com/150044/diff/1/4 File ly/music-functions-init.ly (left): http://codereview.appspot.com/150044/diff/1/4#oldcode604 ly/music-functions-init.ly:604: (ly:music-property main-note 'elements)))) with (lambda http://codereview.appspot.com/150044/diff/1/4 File ly/music-functions-init.ly (right): ...
9 years, 7 months ago (2009-11-08 21:40:28 UTC) #3
Ian Hulin
Have also looked for traling spaces in lily-library.scm http://codereview.appspot.com/150044/diff/1/4 File ly/music-functions-init.ly (right): http://codereview.appspot.com/150044/diff/1/4#newcode612 ly/music-functions-init.ly:612: (lambda ...
9 years, 7 months ago (2009-11-09 11:16:56 UTC) #4
Ian Hulin
Hi all, Is it O K to push this patch now? If so, can either ...
9 years, 7 months ago (2009-11-11 22:57:52 UTC) #5
Carl
A few whitespace errors (tab following spaces) and one indenting mistake. Then I think it's ...
9 years, 7 months ago (2009-11-12 01:12:35 UTC) #6
Neil Puttock
On 2009/11/12 01:12:35, Carl wrote: > A few whitespace errors (tab following spaces) and one ...
9 years, 7 months ago (2009-11-12 20:53:58 UTC) #7
Neil Puttock
http://codereview.appspot.com/150044/diff/11/1015 File ly/music-functions-init.ly (right): http://codereview.appspot.com/150044/diff/11/1015#newcode621 ly/music-functions-init.ly:621: (forced (ly:music-property (car sec-note-events ) 'force-accidental))) (car sec-note-events) http://codereview.appspot.com/150044/diff/11/1015#newcode623 ...
9 years, 7 months ago (2009-11-12 20:54:40 UTC) #8
Neil Puttock
On 2009/11/12 01:12:35, Carl wrote: > A few whitespace errors (tab following spaces) and one ...
9 years, 7 months ago (2009-11-12 21:07:21 UTC) #9
Ian Hulin
9 years, 7 months ago (2009-11-12 21:42:17 UTC) #10
music-functions-init.ly
 spaces+tab lines sorted.
 indentation ll 626-633 fixed.

Is the patch ready to push now?

Cheers,
Ian

http://codereview.appspot.com/150044/diff/11/1015
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/150044/diff/11/1015#newcode611
ly/music-functions-init.ly:611: (filter
On 2009/11/12 01:12:36, Carl wrote:
> Tab following space -- we never want to have that.  Start the line with as
many
> tabs as desired, followed by spaces if necessary to create the proper
> indentation.  Or use all spaces -- that's fine too.  But not space tab space.

Done.

http://codereview.appspot.com/150044/diff/11/1015#newcode612
ly/music-functions-init.ly:612: (lambda (m) (eq? 'NoteEvent (ly:music-property m
'name)))
On 2009/11/12 01:12:36, Carl wrote:
> Tab following space

Done.

http://codereview.appspot.com/150044/diff/11/1015#newcode613
ly/music-functions-init.ly:613: (ly:music-property ev-chord 'elements))))
On 2009/11/12 01:12:36, Carl wrote:
> Tab following space

Done.

http://codereview.appspot.com/150044/diff/11/1015#newcode626
ly/music-functions-init.ly:626: (begin
On 2009/11/12 01:12:36, Carl wrote:
> After changing for-each, you'll need to change (begin to match.

Done.

http://codereview.appspot.com/150044/diff/11/1015#newcode633
ly/music-functions-init.ly:633: trill-events)))))
On 2009/11/12 01:12:36, Carl wrote:
> Tab following spaces

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b