CPP: Remove uses of std::{cerr,endl} in production code.

CPP: Remove uses of std::{cerr,endl} in production code.

They generated static initializers on Clang/Mac.

This also adds the previously missing <algorithm> include in unicodetext.cc
causing a compilation error on VS2013.

This is a squash of (very slightly modified) patches contributed by thakis@ and
yosin@.

R=roes@google.com

Committed: https://code.google.com/p/libphonenumber/source/detail?r=621

[roes, 2013-10-18 09:47:39]

On 2013/10/18 08:55:18, pliard1 wrote:

LGTM.

Not that familiar with the c++ library, but looks good. However not sure why the
logging is different in unicodetext.cc.

[roes, 2013-10-18 09:48:03]

https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unico...
File cpp/src/phonenumbers/utf/unicodetext.cc (right):

https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unico...
cpp/src/phonenumbers/utf/unicodetext.cc:234: fprintf(stderr, "UTF-8 buffer is
not interchange-valid.\n");
Is there a reason this doesn't use LOG(...) like the other classes?

[pliard1, 2013-10-18 09:53:28]

Thanks Cecilia!

https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unico...
File cpp/src/phonenumbers/utf/unicodetext.cc (right):

https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unico...
cpp/src/phonenumbers/utf/unicodetext.cc:234: fprintf(stderr, "UTF-8 buffer is
not interchange-valid.\n");
On 2013/10/18 09:48:03, roes wrote:
> Is there a reason this doesn't use LOG(...) like the other classes?

Yeah, this doesn't depend on headers in the above "layer" (i.e. it only depends
on what's in utf/). I would like to keep this property true if you don't mind :)

[roes, 2013-10-18 09:55:10]

Thanks for the explanation.


On Fri, Oct 18, 2013 at 11:53 AM, <pliard@chromium.org> wrote:

> Thanks Cecilia!
>
>
>
> https://codereview.appspot.**com/14930044/diff/1/cpp/src/**
>
phonenumbers/utf/unicodetext.**cc<https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unicodetext.cc>
> File cpp/src/phonenumbers/utf/**unicodetext.cc (right):
>
> https://codereview.appspot.**com/14930044/diff/1/cpp/src/**
>
phonenumbers/utf/unicodetext.**cc#newcode234<https://codereview.appspot.com/14930044/diff/1/cpp/src/phonenumbers/utf/unicodetext.cc#newcode234>
> cpp/src/phonenumbers/utf/**unicodetext.cc:234: fprintf(stderr, "UTF-8
> buffer is not interchange-valid.\n");
> On 2013/10/18 09:48:03, roes wrote:
>
>> Is there a reason this doesn't use LOG(...) like the other classes?
>>
>
> Yeah, this doesn't depend on headers in the above "layer" (i.e. it only
> depends on what's in utf/). I would like to keep this property true if
> you don't mind :)
>
>
https://codereview.appspot.**com/14930044/<https://codereview.appspot.com/149...
>

[pliard1, 2013-10-18 09:56:18]

Committed patchset #1 manually as r621 (presubmit successful).

[thakis, 2013-10-18 14:26:01]

For what it's worth, this isn't specific to Mac nor Clang. Including <iostream>
inserts a static initializer with libstdc++'s iostream file.

[thakis, 2013-10-18 14:26:17]

…and thanks for landing!


On Fri, Oct 18, 2013 at 2:56 AM, <pliard@chromium.org> wrote:

> Committed patchset #1 manually as r621 (presubmit successful).
>
>
https://codereview.appspot.**com/14930044/<https://codereview.appspot.com/149...
>

[pliard1, 2013-10-18 14:29:49]

On 2013/10/18 14:26:17, thakis wrote:
> …and thanks for landing!
> 
> 
> On Fri, Oct 18, 2013 at 2:56 AM, <mailto:pliard@chromium.org> wrote:
> 
> > Committed patchset #1 manually as r621 (presubmit successful).
> >
> >
>
https://codereview.appspot.**com/14930044/%3Chttps://codereview.appspot.com/1...>
> >

Ah thanks for the info! I will prepare a roll on the Chromium side.

[tamutharlay, 2014-11-20 00:41:12]

On 2013/10/18 14:29:49, pliard1 wrote:
> On 2013/10/18 14:26:17, thakis wrote:
> > …and thanks for landing!
> > 
> > 
> > On Fri, Oct 18, 2013 at 2:56 AM, <mailto:pliard@chromium.org> wrote:
> > 
> > > Committed patchset #1 manually as r621 (presubmit successful).
> > >
> > >
> >
>
https://codereview.appspot.**com/14930044/%3Chttps://codereview.appspot.com/1...>
> > >
> 
> Ah thanks for the info! I will prepare a roll on the Chromium side.

#1 manually as r621 (presubmit successful).

[tamutharlay, 2014-11-24 05:48:45]

On Thursday, November 20, 2014, <tamutharlay@gmail.com> wrote:
> On 2013/10/18 14:29:49, pliard1 wrote:
>>
>> On 2013/10/18 14:26:17, thakis wrote:
>> > ...and thanks for landing!
>> >
>> >
>> > On Fri, Oct 18, 2013 at 2:56 AM, <mailto:pliard@chromium.org> wrote:
>> >
>> > > Committed patchset #1 manually as r621 (presubmit successful).
>> > >
>> > >
>> >
>
> https://codereview.appspot.**com/14930044/%3Chttps://
codereview.appspot.com/14930044/>
>>
>> > >
>
>> Ah thanks for the info! I will prepare a roll on the Chromium side.
>
> #1 manually as r621 (presubmit successful).
>
> https://codereview.appspot.com/14930044/
>

-- 
Kyaw