Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 148940044: code review 148940044: spec: clarify scope and re-use of iteration variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by gri
Modified:
5 years, 6 months ago
Reviewers:
r, rsc, iant
CC:
r, rsc, iant, ken2, golang-codereviews
Visibility:
Public.

Description

spec: clarify scope and re-use of iteration variables Fixes issue 7834.

Patch Set 1 #

Patch Set 2 : diff -r 9b457baf611b2868591c5f00ce842bdecc3d2bfa https://code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r 032fdf145bf989b31b6c7d369c36c4b54066f55a https://code.google.com/p/go #

Patch Set 4 : diff -r c36b86babbafc55b5fd53ba16805923f23166552 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go_spec.html View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8
gri
Hello r, rsc, iant, ken2 (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...
5 years, 6 months ago (2014-09-24 23:28:37 UTC) #1
gri
Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
5 years, 6 months ago (2014-09-24 23:30:01 UTC) #2
iant
LGTM
5 years, 6 months ago (2014-09-25 00:21:26 UTC) #3
r
https://codereview.appspot.com/148940044/diff/20001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/148940044/diff/20001/doc/go_spec.html#newcode4681 doc/go_spec.html:4681: of the "for" statement; they are re-used in each ...
5 years, 6 months ago (2014-09-25 00:43:51 UTC) #4
gri
PTAL https://codereview.appspot.com/148940044/diff/20001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/148940044/diff/20001/doc/go_spec.html#newcode4681 doc/go_spec.html:4681: of the "for" statement; they are re-used in ...
5 years, 6 months ago (2014-09-25 04:13:50 UTC) #5
rsc
LGTM
5 years, 6 months ago (2014-09-25 19:10:13 UTC) #6
r
LGTM
5 years, 6 months ago (2014-09-25 19:23:01 UTC) #7
gri
5 years, 6 months ago (2014-09-25 19:52:12 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=10acb79292cc ***

spec: clarify scope and re-use of iteration variables

Fixes issue 7834.

LGTM=iant, rsc, r
R=r, rsc, iant, ken
CC=golang-codereviews
https://codereview.appspot.com/148940044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b