Do not overwrite http.Client's transport

Do not overwrite http.Client's transport

Ensure that http.Client's transport has DisableKeepAlives=true
without ovwrwriting the transport itself.

https://code.launchpad.net/~wallyworld/goose/better-http-transport-fix/+merge/191740

(do not edit description out of merge proposal)

[wallyworld, 2013-10-18 01:54:23]

Please take a look.

[thumper, 2013-10-18 01:58:27]

https://codereview.appspot.com/14840043/diff/1/http/client.go
File http/client.go (right):

https://codereview.appspot.com/14840043/diff/1/http/client.go#newcode36
http/client.go:36: http.DefaultTransport.(*http.Transport).DisableKeepAlives =
true
You don't want this line right?

[wallyworld, 2013-10-18 02:02:53]

https://codereview.appspot.com/14840043/diff/1/http/client.go
File http/client.go (right):

https://codereview.appspot.com/14840043/diff/1/http/client.go#newcode36
http/client.go:36: http.DefaultTransport.(*http.Transport).DisableKeepAlives =
true
On 2013/10/18 01:58:27, thumper wrote:
> You don't want this line right?

I think it's needed. What if a new http client is set up later and uses the
default transport. That's why I did this.

[thumper, 2013-10-18 02:14:51]

https://codereview.appspot.com/14840043/diff/1/http/client.go
File http/client.go (right):

https://codereview.appspot.com/14840043/diff/1/http/client.go#newcode36
http/client.go:36: http.DefaultTransport.(*http.Transport).DisableKeepAlives =
true
On 2013/10/18 02:02:54, wallyworld wrote:
> On 2013/10/18 01:58:27, thumper wrote:
> > You don't want this line right?
> 
> I think it's needed. What if a new http client is set up later and uses the
> default transport. That's why I did this.

Hmm.. ok. What about the other changes that are in gwacl, goose etc that
replaced the default transport?

[thumper, 2013-10-18 02:23:44]

On 2013/10/18 02:14:51, thumper wrote:
> https://codereview.appspot.com/14840043/diff/1/http/client.go
> File http/client.go (right):
> 
> https://codereview.appspot.com/14840043/diff/1/http/client.go#newcode36
> http/client.go:36: http.DefaultTransport.(*http.Transport).DisableKeepAlives =
> true
> On 2013/10/18 02:02:54, wallyworld wrote:
> > On 2013/10/18 01:58:27, thumper wrote:
> > > You don't want this line right?
> > 
> > I think it's needed. What if a new http client is set up later and uses the
> > default transport. That's why I did this.
> 
> Hmm.. ok. What about the other changes that are in gwacl, goose etc that
> replaced the default transport?

Didn't notice that this one is goose.

LGTM