Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12681)

Issue 14741045: provider/maas: do not use environ-uuid

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rog
Modified:
10 years, 6 months ago
Reviewers:
natefinch, gz, mp+191367, rvb
Visibility:
Public.

Description

provider/maas: do not use environ-uuid As pointed out by fwereade, it could be confusing to have two things in the system that both purport to be a uuid for the environ. Also make the MAAS EnvironProvider.Validate check that we're not changing the maas-instance-uuid. https://code.launchpad.net/~rogpeppe/juju-core/453-maas-instance-uuid/+merge/191367 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provider/maas: do not use environ-uuid #

Patch Set 3 : provider/maas: do not use environ-uuid #

Patch Set 4 : provider/maas: do not use environ-uuid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -57 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M provider/maas/config.go View 1 2 3 chunks +12 lines, -6 lines 0 comments Download
M provider/maas/config_test.go View 1 2 3 2 chunks +23 lines, -7 lines 0 comments Download
M provider/maas/environ.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M provider/maas/environ_test.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M provider/maas/environprovider.go View 1 2 3 1 chunk +12 lines, -15 lines 0 comments Download
M provider/maas/environprovider_test.go View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M provider/maas/maas_test.go View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M provider/maas/storage.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M provider/maas/storage_test.go View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
10 years, 6 months ago (2013-10-16 11:35:02 UTC) #1
gz
LGTM. We will need to be careful when we fiddle with this mechanism in future ...
10 years, 6 months ago (2013-10-16 12:21:50 UTC) #2
natefinch
LGTM, although I'd prefer if someone factored out all the magic strings.
10 years, 6 months ago (2013-10-16 12:29:18 UTC) #3
rog
Please take a look.
10 years, 6 months ago (2013-10-16 12:36:00 UTC) #4
rog
Please take a look.
10 years, 6 months ago (2013-10-16 12:46:11 UTC) #5
rvb
10 years, 6 months ago (2013-10-16 12:57:34 UTC) #6
LTGM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b