Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 14670043: Juju Quickstart plugin base structure.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by frankban
Modified:
10 years, 5 months ago
Reviewers:
matthew.scott, gary.poster, mp+190991
Visibility:
Public.

Description

Juju Quickstart plugin base structure. Base project structure including command entry point, distribution files, test runner and a way to create the development environment. The diff is long, but it there are header files, the license information and other boiler plate code that can be ignored. Tests: make check. https://code.launchpad.net/~frankban/juju-gui/quickstart-initial/+merge/190991 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Juju Quickstart plugin base structure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1109 lines, -0 lines) Patch
A .bzrignore View 1 chunk +8 lines, -0 lines 0 comments Download
A .lbox View 1 chunk +1 line, -0 lines 0 comments Download
A .lbox.check View 1 chunk +3 lines, -0 lines 0 comments Download
A COPYING View 1 chunk +661 lines, -0 lines 0 comments Download
A HACKING.rst View 1 chunk +74 lines, -0 lines 0 comments Download
A Makefile View 1 chunk +81 lines, -0 lines 0 comments Download
A README.rst View 1 chunk +9 lines, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A juju-quickstart View 1 chunk +26 lines, -0 lines 0 comments Download
A quickstart/__init__.py View 1 chunk +27 lines, -0 lines 0 comments Download
A quickstart/manage.py View 1 chunk +61 lines, -0 lines 0 comments Download
A quickstart/tests/__init__.py View 1 chunk +15 lines, -0 lines 0 comments Download
A quickstart/tests/test_manage.py View 1 chunk +41 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +76 lines, -0 lines 0 comments Download
A test-requirements.pip View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 5 months ago (2013-10-14 15:59:25 UTC) #1
matthew.scott
LGTM, thanks for a great start!
10 years, 5 months ago (2013-10-14 20:13:50 UTC) #2
gary.poster
+1 to what Makyo said. If you want another LGTM, here it is. :-)
10 years, 5 months ago (2013-10-14 20:23:16 UTC) #3
frankban
*** Submitted: Juju Quickstart plugin base structure. Base project structure including command entry point, distribution ...
10 years, 5 months ago (2013-10-15 07:13:13 UTC) #4
frankban
10 years, 5 months ago (2013-10-15 07:17:43 UTC) #5
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b