Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2606)

Issue 14619045: state: make Addresses use Machine.Addresses

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by rog
Modified:
6 years ago
Reviewers:
mp+191686, natefinch
Visibility:
Public.

Description

state: make Addresses use Machine.Addresses ... and APIAddresses likewise. This requires changing some tests so that there is actually a machine that pretends to be the state server. https://code.launchpad.net/~rogpeppe/juju-core/451-state-addresses/+merge/191686 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: make Addresses use Machine.Addresses #

Total comments: 8

Patch Set 3 : state: make Addresses use Machine.Addresses #

Patch Set 4 : state: make Addresses use Machine.Addresses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -116 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine_test.go View 2 chunks +10 lines, -2 lines 0 comments Download
M juju/testing/utils.go View 2 chunks +18 lines, -0 lines 0 comments Download
M provider/local/environ.go View 1 2 3 2 chunks +18 lines, -2 lines 0 comments Download
M state/address.go View 2 chunks +75 lines, -0 lines 0 comments Download
M state/api/deployer/deployer_test.go View 2 chunks +7 lines, -2 lines 0 comments Download
M state/api/provisioner/provisioner_test.go View 3 chunks +14 lines, -3 lines 0 comments Download
M state/apiserver/common/addresses.go View 1 2 4 chunks +17 lines, -39 lines 0 comments Download
M state/apiserver/common/addresses_test.go View 1 2 2 chunks +22 lines, -9 lines 0 comments Download
M state/apiserver/deployer/deployer_test.go View 3 chunks +14 lines, -2 lines 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M state/open.go View 2 chunks +0 lines, -29 lines 0 comments Download
M state/state_test.go View 3 chunks +48 lines, -23 lines 0 comments Download
M worker/provisioner/lxc-broker_test.go View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M worker/provisioner/provisioner_test.go View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
6 years, 1 month ago (2013-10-17 17:58:40 UTC) #1
natefinch
LGTM with a couple very minor nitpicks. https://codereview.appspot.com/14619045/diff/4001/state/apiserver/common/addresses.go File state/apiserver/common/addresses.go (right): https://codereview.appspot.com/14619045/diff/4001/state/apiserver/common/addresses.go#newcode12 state/apiserver/common/addresses.go:12: // It ...
6 years, 1 month ago (2013-10-18 13:07:33 UTC) #2
rog
Please take a look. https://codereview.appspot.com/14619045/diff/4001/state/apiserver/common/addresses.go File state/apiserver/common/addresses.go (right): https://codereview.appspot.com/14619045/diff/4001/state/apiserver/common/addresses.go#newcode12 state/apiserver/common/addresses.go:12: // It is implemented by ...
6 years, 1 month ago (2013-10-18 14:09:05 UTC) #3
rog
6 years ago (2013-10-31 12:13:32 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b