Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 14590043: code review 14590043: go.crypto/openpgp: support v3 detached signatures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by agl1
Modified:
5 years, 11 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

go.crypto/openpgp: support v3 detached signatures. Although the package doesn't attempt to fully support ancient, version 3 messages, supporting v3 detached signatures is fairly easy and some projects (in this case, Ubuntu) are using them for unknown reasons.

Patch Set 1 #

Patch Set 2 : diff -r ede3e37127cc https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r ede3e37127cc https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r ede3e37127cc https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M openpgp/read.go View 1 2 chunks +25 lines, -9 lines 0 comments Download
M openpgp/read_test.go View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
5 years, 11 months ago (2013-10-09 21:06:12 UTC) #1
r
LGTM
5 years, 11 months ago (2013-10-09 21:14:20 UTC) #2
agl1
5 years, 11 months ago (2013-10-09 21:24:42 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=812c06b5a384&repo=crypto ***

go.crypto/openpgp: support v3 detached signatures.

Although the package doesn't attempt to fully support ancient, version
3 messages, supporting v3 detached signatures is fairly easy and some
projects (in this case, Ubuntu) are using them for unknown reasons.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14590043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b