Issue 145360043: code review 145360043: go.tools/cmd/vet: warn about copying locks in range sta...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 145360043: code review 145360043: go.tools/cmd/vet: warn about copying locks in range sta... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by josharian

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
r, dsymonds, golang-codereviews

Visibility:
Public.

Description

go.tools/cmd/vet: warn about copying locks in range statements Fixes issue 8356.

Patch Set 1 #

Patch Set 2 : diff -r 58c81fe7a980a34a236b3dd7b1256e5fc1d648a5 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 58c81fe7a980a34a236b3dd7b1256e5fc1d648a5 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 58c81fe7a980a34a236b3dd7b1256e5fc1d648a5 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 9c7110ab58402df527dbf8373d0fa888000779d4 https://code.google.com/p/go.tools #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -7 lines)			Patch
M	cmd/vet/copylock.go	View	1	3 chunks	+55 lines, -6 lines	0 comments	Download
M	cmd/vet/testdata/copylock_func.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	cmd/vet/testdata/copylock_range.go	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

josharian

Hello r@golang.org, dsymonds@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

9 years, 7 months ago (2014-09-24 19:13:46 UTC) #1

josharian

9 years, 7 months ago (2014-09-24 19:35:15 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=fdc9402f4eec&repo=tools ***

go.tools/cmd/vet: warn about copying locks in range statements

Fixes issue 8356.

LGTM=r
R=r, dsymonds
CC=golang-codereviews
https://codereview.appspot.com/145360043

Expand All Messages | Collapse All Messages