Issue 14515049: Added bundle details panel icon and visibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14515049: Added bundle details panel icon and visibility (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by huwshimi

Modified:
10 years, 6 months ago

Reviewers:
mp+190277, gary.poster

Visibility:
Public.

Description

Added bundle details panel icon and visibility On the bundle details overview I added the charm icon to the charm details panel. I also added showing and hiding of that panel. https://code.launchpad.net/~huwshimi/juju-gui/bundle-details-icon/+merge/190277 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/bundle-service-details.handlebars	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	app/views/topology/bundle.js	View	3 chunks	+16 lines, -1 line	0 comments	Download
M	lib/views/browser/bundle-panel.less	View	2 chunks	+21 lines, -4 lines	0 comments	Download
M	test/test_bundle_module.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

huwshimi

On 2013/10/10 00:43:37, huwshimi wrote: > Please take a look. To test browse to http://localhost:8888/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=wiki ...

10 years, 6 months ago (2013-10-10 00:44:49 UTC) #2

gary.poster

10 years, 6 months ago (2013-10-10 11:20:20 UTC) #4

*** Submitted:

Added bundle details panel icon and visibility

On the bundle details overview I added the charm icon to the charm details
panel. I also added showing and hiding of that panel.

R=gary.poster
CC=
https://codereview.appspot.com/14515049

Expand All Messages | Collapse All Messages