Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(252)

Issue 145020044: Switch swarming.py to use the new client API, add flags, print more info. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by M-A
Modified:
10 years, 9 months ago
Reviewers:
vadimsh
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Switch swarming.py to use the new client API, add flags, print more info. - Rename --deadline to --expiration. - Add --user, --io-timeout, --hard-timeout and --tags. - The switch to the new API will permit to get rid of the old client API on the server. - Print url in "swarming.py trigger" for easier copy-paste, in addition to the copy-pasteable command. Useful when looking at the logs in a web browser. - Fix swarming_smoke_test.py which regressed since 4566ecf76b. R=vadimsh@chromium.org BUG=swarming:118 Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=2f6581a2479ec3d404c110a6ea2ff6f8b8e081ed

Patch Set 1 : . #

Total comments: 8

Patch Set 2 : Improved #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -769 lines) Patch
M auth.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M swarming.py View 1 2 18 chunks +161 lines, -222 lines 0 comments Download
M tests/swarming_smoke_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/swarming_test.py View 27 chunks +288 lines, -545 lines 0 comments Download

Messages

Total messages: 6
M-A
After that, it'll be easier to add more features.
10 years, 9 months ago (2014-10-01 17:28:22 UTC) #1
vadimsh
lgtm with nits my main concern is 'unknown' user https://codereview.appspot.com/145020044/diff/80001/swarming.py File swarming.py (right): https://codereview.appspot.com/145020044/diff/80001/swarming.py#newcode405 swarming.py:405: ...
10 years, 9 months ago (2014-10-01 19:41:23 UTC) #2
M-A
https://codereview.appspot.com/145020044/diff/80001/swarming.py File swarming.py (right): https://codereview.appspot.com/145020044/diff/80001/swarming.py#newcode405 swarming.py:405: # TODO(maruel): Get rid of this. On 2014/10/01 19:41:22, ...
10 years, 9 months ago (2014-10-01 20:38:28 UTC) #3
vadimsh
lgtm with nits https://codereview.appspot.com/145020044/diff/100001/auth.py File auth.py (right): https://codereview.appspot.com/145020044/diff/100001/auth.py#newcode92 auth.py:92: return nit: return None https://codereview.appspot.com/145020044/diff/100001/swarming.py File ...
10 years, 9 months ago (2014-10-01 23:50:46 UTC) #4
M-A
https://codereview.appspot.com/145020044/diff/100001/auth.py File auth.py (right): https://codereview.appspot.com/145020044/diff/100001/auth.py#newcode92 auth.py:92: return On 2014/10/01 23:50:46, vadimsh wrote: > nit: return ...
10 years, 9 months ago (2014-10-03 15:09:32 UTC) #5
M-A
10 years, 9 months ago (2014-10-03 15:10:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:120001) manually as
2f6581a2479ec3d404c110a6ea2ff6f8b8e081ed (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b