Issue 14486046: Make cw code tests tz agnostic.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14486046: Make cw code tests tz agnostic.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by bac

Modified:
10 years, 6 months ago

Reviewers:
rharding, mp+191291

Visibility:
Public.

Description

Make cw code tests tz agnostic. In the past there have been some incredibly hard to debug test failures caused by using .now() vs .utcnow(). During a routine inspection I saw various instances of .now() being used and have replaced them. Added a .lbox to use -cr on propose by default and set the project to lp:charmworld. Fixed the testdebug target to stop on failures in addition to errors. https://code.launchpad.net/~bac/charmworld/utc-smackdown/+merge/191291 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make cw code tests tz agnostic. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
.lbox	View	1 chunk	+1 line, -0 lines	0 comments	Download
Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
charmworld/jobs/tests/test_askubuntu.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
charmworld/jobs/tests/test_review.py	View	1 chunk	+1 line, -1 line	0 comments	Download
charmworld/migrations/migrate.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
charmworld/reports.py	View	1 chunk	+1 line, -1 line	0 comments	Download
charmworld/tests/test_utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download
charmworld/utils.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM reviewed on LP due to the chunk mismatch.

Expand All Messages | Collapse All Messages