Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 14430061: Fix initial coordinates for annotated services

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by matthew.scott
Modified:
10 years, 5 months ago
Reviewers:
mp+191034, gary.poster
Visibility:
Public.

Description

Fix initial coordinates for annotated services As services with annotations have those annotations removed after placement, further updates to the DB were causing them to be treated as new services in a short-circuit || check. They were initially placed at the annotated positions, then re-positioned as default new services on any further updates to the database (e.g.: GetCharm, etc.). This treats them as old services as soon as they've been received by the first delta with their annotations intact by utilizing the already-existing hasBeenPositioned flag which bypasses that check; no more auto-positioning. Asserts added to the appropriate test. https://code.launchpad.net/~makyo/juju-gui/coords/+merge/191034 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/test_environment_view.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
matthew.scott
Please take a look.
10 years, 5 months ago (2013-10-14 19:30:23 UTC) #1
gary.poster
10 years, 5 months ago (2013-10-14 20:55:25 UTC) #2
Thanks Matt.  LGTM and qa ok (as we said on IRC, there's a lot of positioning
bugs atm but they are separate from and additional to this branch, except
possibly the deletion of gui-x and gui-y annotations as a problematic pattern).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b