Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(627)

Issue 144048: Added IPv6 extensions

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by faker.moatamri
Modified:
5 years, 7 months ago
Reviewers:
faker.moatamri
Visibility:
Public.

Patch Set 1 #

Total comments: 65
Unified diffs Side-by-side diffs Delta from patch set Stats (+5215 lines, -20 lines) Patch
A examples/ipv6/fragmentation-ipv6.cc View 1 chunk +164 lines, -0 lines 8 comments Download
M examples/ipv6/icmpv6-redirect.cc View 1 chunk +1 line, -1 line 0 comments Download
A examples/ipv6/loose-routing-ipv6.cc View 1 chunk +171 lines, -0 lines 3 comments Download
M examples/ipv6/wscript View 1 chunk +7 lines, -0 lines 0 comments Download
M src/applications/ping6/ping6.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/applications/ping6/ping6.cc View 5 chunks +25 lines, -3 lines 2 comments Download
M src/applications/radvd/radvd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/internet-stack-helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/helper/ping6-helper.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/helper/ping6-helper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/internet-stack/icmpv6-l4-protocol.cc View 1 chunk +6 lines, -1 line 0 comments Download
A src/internet-stack/ipv6-extension.h View 1 chunk +591 lines, -0 lines 2 comments Download
A src/internet-stack/ipv6-extension.cc View 1 chunk +1084 lines, -0 lines 30 comments Download
A src/internet-stack/ipv6-extension-demux.h View 1 chunk +102 lines, -0 lines 3 comments Download
A src/internet-stack/ipv6-extension-demux.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A src/internet-stack/ipv6-extension-header.h View 1 chunk +649 lines, -0 lines 2 comments Download
A src/internet-stack/ipv6-extension-header.cc View 1 chunk +597 lines, -0 lines 2 comments Download
M src/internet-stack/ipv6-l3-protocol.h View 3 chunks +12 lines, -0 lines 0 comments Download
M src/internet-stack/ipv6-l3-protocol.cc View 7 chunks +215 lines, -3 lines 7 comments Download
A src/internet-stack/ipv6-option.h View 1 chunk +269 lines, -0 lines 0 comments Download
A src/internet-stack/ipv6-option.cc View 1 chunk +242 lines, -0 lines 2 comments Download
A src/internet-stack/ipv6-option-demux.h View 1 chunk +105 lines, -0 lines 0 comments Download
A src/internet-stack/ipv6-option-demux.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A src/internet-stack/ipv6-option-header.h View 1 chunk +385 lines, -0 lines 0 comments Download
A src/internet-stack/ipv6-option-header.cc View 1 chunk +342 lines, -0 lines 0 comments Download
M src/internet-stack/wscript View 3 chunks +8 lines, -1 line 0 comments Download
M src/node/ipv6.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/routing/static-routing/ipv6-static-routing.h View 2 chunks +8 lines, -8 lines 2 comments Download
M src/routing/static-routing/ipv6-static-routing.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 3
moatamri
Review of IPv6 extensions http://codereview.appspot.com/144048/diff/1/2 File examples/ipv6/fragmentation-ipv6.cc (right): http://codereview.appspot.com/144048/diff/1/2#newcode66 Line 66: inline void PrintRoutingTable (Ptr<Node>& ...
11 years, 5 months ago (2009-10-30 11:31:30 UTC) #1
ping67
Repository http://svnet.u-strasbg.fr/hg/ns-3-ipv6-ext/ has been updated. http://codereview.appspot.com/144048/diff/1/2 File examples/ipv6/fragmentation-ipv6.cc (right): http://codereview.appspot.com/144048/diff/1/2#newcode66 Line 66: inline void PrintRoutingTable ...
11 years, 5 months ago (2009-11-02 17:09:10 UTC) #2
ping67
11 years, 5 months ago (2009-11-11 15:31:33 UTC) #3
http://codereview.appspot.com/144048/diff/1/17
File src/internet-stack/ipv6-extension.cc (right):

http://codereview.appspot.com/144048/diff/1/17#newcode236
src/internet-stack/ipv6-extension.cc:236: uint8_t
Ipv6ExtensionDestination::Process (Ptr<Packet>& packet, uint8_t offset,
Ipv6Header const& ipv6Header, Ipv6Address dst, uint8_t *nextHeader, bool&
isDropped)
On 2009/11/02 17:09:10, ping67 wrote:
> I will think of this at the end of week or next week.
> 

Done.

http://codereview.appspot.com/144048/diff/1/17#newcode271
src/internet-stack/ipv6-extension.cc:271: if (ipv6Option == 0)
On 2009/10/30 11:31:30, moatamri wrote:
> same comments as the above similar function

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b