Issue 14388046: Fix missing dependency and upgrade Tornado.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14388046: Fix missing dependency and upgrade Tornado.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by frankban

Modified:
10 years, 6 months ago

Reviewers:
mp+189333

Visibility:
Public.

Description

Fix missing dependency and upgrade Tornado. Upgrade Tornado to version 3.1.1 and add the websocket-client dependency. https://code.launchpad.net/~frankban/charms/precise/juju-gui/upgrade-tornado/+merge/189333 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix missing dependency and upgrade Tornado. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	deps/tornado-3.1.1.tar.gz	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	deps/tornado-3.1.tar.gz	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	deps/websocket-client-0.12.0.tar.gz	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	hooks/utils.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/requirements.pip	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

10 years, 6 months ago (2013-10-04 14:52:55 UTC) #3

*** Submitted:

Fix missing dependency and upgrade Tornado.

Upgrade Tornado to version 3.1.1 and add 
the websocket-client dependency.

R=
CC=
https://codereview.appspot.com/14388046

Expand All Messages | Collapse All Messages