Issue 14299043: code review 14299043: go.tools/dashboard: Don't keep unversioned directories ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14299043: code review 14299043: go.tools/dashboard: Don't keep unversioned directories ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by cmang

Modified:
10 years, 6 months ago

Reviewers:
adg

CC:
adg1, adg, golang-dev

Visibility:
Public.

Description

go.tools/dashboard: Don't keep unversioned directories in gcc copy. `svn update` would fail if the updated files were in the gcc/libgo or gcc/go/gofrontend because unrevisioned versions of those files had been inserted in the last build of gcc.

Patch Set 1 #

Patch Set 2 : diff -r 28bee64fb2d0 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 28bee64fb2d0 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 53cacae97b54 https://code.google.com/p/go.tools #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	dashboard/builder/env.go	View	1	4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

cmang

Hello adg@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 6 months ago (2013-10-02 19:14:20 UTC) #1

cmang

10 years, 6 months ago (2013-10-02 22:56:29 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=75d0b69fdb10&repo=tools ***

go.tools/dashboard: Don't keep unversioned directories in gcc copy.

`svn update` would fail if the updated files were in the gcc/libgo or
gcc/go/gofrontend because unrevisioned versions of those files had been inserted
in the last build of gcc.

R=adg, adg
CC=golang-dev
https://codereview.appspot.com/14299043

Expand All Messages | Collapse All Messages