Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2250)

Issue 14297043: code review 14297043: go.tools/dashboard: Make sure links to commits and logs... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by cmang
Modified:
10 years, 6 months ago
Reviewers:
adg
CC:
adg, golang-dev
Visibility:
Public.

Description

go.tools/dashboard: Make sure links to commits and logs are dashboard specific.

Patch Set 1 #

Patch Set 2 : diff -r 28bee64fb2d0 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 28bee64fb2d0 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 28bee64fb2d0 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r a0e348e37561 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M dashboard/app/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dashboard/app/build/ui.go View 1 1 chunk +4 lines, -1 line 0 comments Download
M dashboard/app/build/ui.html View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
cmang
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 6 months ago (2013-10-02 19:04:49 UTC) #1
adg
LGTM
10 years, 6 months ago (2013-10-02 22:49:41 UTC) #2
cmang
10 years, 6 months ago (2013-10-02 22:55:47 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=53cacae97b54&repo=tools ***

go.tools/dashboard: Make sure links to commits and logs are dashboard specific.

R=adg
CC=golang-dev
https://codereview.appspot.com/14297043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b