Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1573)

Issue 14266043: provider/azure: remove default daily stream

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by axw
Modified:
10 years, 6 months ago
Reviewers:
mp+188777, axw1, jameinel
Visibility:
Public.

Description

provider/azure: remove default daily stream The simplestreams.GetMetadata function was being called with three datasources: storage, daily and released. In our tests, storage was empty, but daily and released were not; daily did not, however, have any matching image ids. There's an issue with simplestreams.GetMetadata not attempting the next datasource if the metadata index is valid, but does not contain any matching product IDs. Since the behaviour of simplestreams.GetMetadata is potentially useful for private clouds, we will just remove the daily stream from the defaults for now. If people really want it, they can get at it with image-stream and image-metadata-url. Fixes #1233924 https://code.launchpad.net/~axwalk/juju-core/lp1233924-azure-disable-daily-stream/+merge/188777 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/azure/environ.go View 1 chunk +5 lines, -3 lines 2 comments Download

Messages

Total messages: 3
axw
Please take a look.
10 years, 6 months ago (2013-10-02 07:54:47 UTC) #1
jameinel
LGTM though a small comment tweak https://codereview.appspot.com/14266043/diff/1/provider/azure/environ.go File provider/azure/environ.go (right): https://codereview.appspot.com/14266043/diff/1/provider/azure/environ.go#newcode904 provider/azure/environ.go:904: // XXX Due ...
10 years, 6 months ago (2013-10-02 07:56:50 UTC) #2
axw1
10 years, 6 months ago (2013-10-02 08:03:18 UTC) #3
https://codereview.appspot.com/14266043/diff/1/provider/azure/environ.go
File provider/azure/environ.go (right):

https://codereview.appspot.com/14266043/diff/1/provider/azure/environ.go#newc...
provider/azure/environ.go:904: // XXX Due to datasource fallback issues, the
default daily stream has been removed.
On 2013/10/02 07:56:50, jameinel wrote:
> I would just say "Note" and not "XXX"

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b