Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(609)

Issue 14210043: Fix blank charm details on browser re-expanding.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
rharding, mp+188622
Visibility:
Public.

Description

Fix blank charm details on browser re-expanding. Minimizing browser with open charm details, and then re-expanding it showed blank content. Also fixed the minimize tab style so that it is not hidden by an open inspector. QA: - go to http://localhost:8888/precise/mediawiki-10/ ; - click on the minimize tab; - click on the tab again to re-expand; The charm details are shown. https://code.launchpad.net/~frankban/juju-gui/detail-minimize/+merge/188622 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix blank charm details on browser re-expanding. #

Patch Set 3 : Fix blank charm details on browser re-expanding. #

Patch Set 4 : Fix blank charm details on browser re-expanding. #

Patch Set 5 : Fix blank charm details on browser re-expanding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/browser.js View 1 6 chunks +15 lines, -15 lines 0 comments Download
M app/subapps/browser/views/sidebar.js View 1 2 chunks +10 lines, -1 line 0 comments Download
M lib/views/browser/browser-icon.less View 1 chunk +1 line, -1 line 0 comments Download
M test/test_browser_app.js View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
10 years, 6 months ago (2013-10-01 15:00:34 UTC) #1
rharding
Code LGTM with the one note that those types are tests are setup below and ...
10 years, 6 months ago (2013-10-01 15:13:49 UTC) #2
frankban
Please take a look.
10 years, 6 months ago (2013-10-02 09:33:43 UTC) #3
frankban
Please take a look.
10 years, 6 months ago (2013-10-02 10:52:13 UTC) #4
rharding
Code LGTM will redo the IE QA.
10 years, 6 months ago (2013-10-02 11:03:18 UTC) #5
rharding
IE QA good, thanks for the fix!
10 years, 6 months ago (2013-10-02 11:09:10 UTC) #6
frankban
10 years, 6 months ago (2013-10-02 11:32:13 UTC) #7
*** Submitted:

Fix blank charm details on browser re-expanding.

Minimizing browser with open charm details, 
and then re-expanding it showed blank content.

Also fixed the minimize tab style so that it is
not hidden by an open inspector.

QA:
- go to http://localhost:8888/precise/mediawiki-10/ ;
- click on the minimize tab;
- click on the tab again to re-expand;  
The charm details are shown.

R=rharding
CC=
https://codereview.appspot.com/14210043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b