Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(289)

Issue 141730043: code review 141730043: net: don't set wrong option for controlling tcp keepali... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by mikio
Modified:
5 years, 6 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

net: don't set wrong option for controlling tcp keepalive on openbsd Fixes issue 8679.

Patch Set 1 : diff -r e54b1af55910c77e4a215112193472f0276b3c8d https://code.google.com/p/go #

Patch Set 2 : diff -r 2a642ae2e6186583899ae9889655d414867e1f68 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2a642ae2e6186583899ae9889655d414867e1f68 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M src/net/tcpsockopt_openbsd.go View 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
5 years, 6 months ago (2014-09-08 08:04:41 UTC) #1
iant
LGTM
5 years, 6 months ago (2014-09-08 15:43:17 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=7b93d8b186dc *** net: don't set wrong option for controlling tcp keepalive on ...
5 years, 6 months ago (2014-09-08 22:22:39 UTC) #3
gobot
5 years, 6 months ago (2014-09-09 00:29:10 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/5fae7c32657dcffdebfe3414bb7cac9a4ab6d30a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b