Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 141058: Add missing planned date when creating inventory and outgoin moves (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by bch
Modified:
10 years, 5 months ago
Reviewers:
timitos, ced1
CC:
bch
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Patch Set 3 : Don't allow all states if stock_date_end is max datetime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M product.py View 2 chunks +2 lines, -5 lines 0 comments Download
M shipment.py View 1 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9
bch
10 years, 5 months ago (2009-10-26 12:06:05 UTC) #1
ced1
http://codereview.appspot.com/141058/diff/1/2 File shipment.py (right): http://codereview.appspot.com/141058/diff/1/2#newcode315 Line 315: res['planned_date'] = False You should add a comment ...
10 years, 5 months ago (2009-10-26 12:45:21 UTC) #2
bch
10 years, 5 months ago (2009-10-26 15:18:55 UTC) #3
ced1
ok
10 years, 5 months ago (2009-10-26 15:23:49 UTC) #4
timitos
This patch is a step in the right direction but it does not solve the ...
10 years, 5 months ago (2009-10-27 07:31:30 UTC) #5
bch
10 years, 5 months ago (2009-10-27 19:57:53 UTC) #6
ced1
On 2009/10/27 19:57:53, bch wrote: > Your patch don't change anything
10 years, 5 months ago (2009-10-27 20:24:47 UTC) #7
ced1
On 2009/10/27 20:24:47, ced wrote: > On 2009/10/27 19:57:53, bch wrote: > > > > ...
10 years, 5 months ago (2009-10-27 20:38:23 UTC) #8
timitos
10 years, 5 months ago (2009-10-27 22:29:01 UTC) #9
ok for me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b