Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 138600043: code review 138600043: image/gif: don't let the per-frame transparent index mo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by nigeltao
Modified:
7 years, 4 months ago
Reviewers:
r
CC:
r, golang-codereviews, james.jdunne_gmail.com
Visibility:
Public.

Description

image/gif: don't let the per-frame transparent index modify the global palette. Fixes issue 7993.

Patch Set 1 #

Patch Set 2 : diff -r 541f4c85dfedb06962ac2d88b3d3bf90d0dc6a53 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 541f4c85dfedb06962ac2d88b3d3bf90d0dc6a53 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 932fe22207465e6c4bcdae29f5c519ba069f8927 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M src/image/gif/reader.go View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/image/gif/reader_test.go View 1 2 chunks +55 lines, -9 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org (cc: golang-codereviews@googlegroups.com, james.jdunne@gmail.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 4 months ago (2014-09-18 04:10:07 UTC) #1
r
LGTM
7 years, 4 months ago (2014-09-18 06:06:30 UTC) #2
nigeltao
7 years, 4 months ago (2014-09-22 04:30:01 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4c2e269181ea ***

image/gif: don't let the per-frame transparent index modify the global
palette.

Fixes issue 7993.

LGTM=r
R=r
CC=golang-codereviews, james.jdunne
https://codereview.appspot.com/138600043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b