Issue 13858045: Fix failing test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13858045: Fix failing test.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by bac

Modified:
10 years, 7 months ago

Reviewers:
mp+187276, jeff.pihach

Visibility:
Public.

Description

Fix failing test. done() was called before the end of setup. https://code.launchpad.net/~bac/juju-gui/bundle-model-2/+merge/187276 (do not edit description out of merge proposal)

Patch Set 2 : Fix failing test. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	test/test_model.js	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM Thanks for the fix https://codereview.appspot.com/13858045/diff/1/test/test_model.js File test/test_model.js (right): https://codereview.appspot.com/13858045/diff/1/test/test_model.js#newcode637 test/test_model.js:637: done(); I have no ...

10 years, 7 months ago (2013-09-24 16:23:19 UTC) #2

bac

10 years, 7 months ago (2013-09-24 17:23:50 UTC) #3

*** Submitted:

Fix failing test.

done() was called before the end of setup.

R=jeff.pihach
CC=
https://codereview.appspot.com/13858045

https://codereview.appspot.com/13858045/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/13858045/diff/1/test/test_model.js#newcode637
test/test_model.js:637: done();
OK, chalk one up for the inexplicable.

Expand All Messages | Collapse All Messages