Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8262)

Issue 13854043: Build: Fix out-of-tree build from tarball. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Julien Rioux
Modified:
10 years, 6 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New description: Bison is made a required dependency again. Also, dependencies for ly-grammar.txt are corrected. Old description: Build: Fix bison-less build from tarball. A couple of fix to make dist: - Update bison-generated files timestamps. - Also include generated files in out-www dir. Otherwise, these files are forced to be rebuilt, but bison is supposed to be optional when building from the tarball.

Patch Set 1 #

Patch Set 2 : Remove echo, leftover from debugging. #

Patch Set 3 : Fix out-of-tree build from tarball. #

Total comments: 4

Patch Set 4 : Remove additional dependencies in Documentation/de #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Documentation/GNUmakefile View 1 2 2 chunks +1 line, -3 lines 2 comments Download
M configure.ac View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/GNUmakefile View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Julien Rioux
Remove echo, leftover from debugging.
10 years, 7 months ago (2013-09-24 08:56:59 UTC) #1
Julien Rioux
Fix out-of-tree build from tarball.
10 years, 6 months ago (2013-10-01 09:46:21 UTC) #2
dak
Basically, LGTM, but I might take a look at the German doc regarding the grammar ...
10 years, 6 months ago (2013-10-01 10:27:07 UTC) #3
Julien Rioux
https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile#newcode283 Documentation/GNUmakefile:283: $(outdir)/contributor.texi: $(outdir)/ly-grammar.txt On 2013/10/01 10:27:08, dak wrote: > As ...
10 years, 6 months ago (2013-10-01 10:34:16 UTC) #4
Julien Rioux
Remove additional dependencies in Documentation/de
10 years, 6 months ago (2013-10-01 12:08:08 UTC) #5
dak
https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile#newcode283 Documentation/GNUmakefile:283: $(outdir)/contributor.texi: $(outdir)/ly-grammar.txt The problem why this is creepier than ...
10 years, 6 months ago (2013-10-02 09:34:19 UTC) #6
Julien Rioux
10 years, 6 months ago (2013-10-02 09:40:50 UTC) #7
https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile
File Documentation/GNUmakefile (right):

https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile#...
Documentation/GNUmakefile:283: $(outdir)/contributor.texi:
$(outdir)/ly-grammar.txt
On 2013/10/02 09:34:19, dak wrote:
> The problem why this is creepier than the original rule is that notation.texi
is
> a generated file (from notation.tely) while contributor.texi is an original
file
> in our repository.
> 

$(outdir)/contributor.texi is a generated file (from contributor.texi; the rule
is a simple copy).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b