Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2044)

Issue 13826047: Make "Adding extra fingering with scheme" snippet do something useful (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make "Adding extra fingering with scheme" snippet do something useful This snippet was never operative in 2.16 due to the EventChord changes of issue 2240. This updates it into using a few 2.16 features in order to make things simpler while retaining the basic purpose. Also: Run scripts/auxiliar/makelsr.py

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -35 lines) Patch
M Documentation/snippets/adding-extra-fingering-with-scheme.ly View 1 chunk +29 lines, -35 lines 0 comments Download
A Documentation/snippets/new/adding-extra-fingering-with-scheme.ly View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 2
thomasmorley651
LGTM Question: considering LSR-update, I recently added an earlier version of it to the LSR ...
10 years, 7 months ago (2013-09-27 23:53:50 UTC) #1
dak
10 years, 6 months ago (2013-10-01 05:55:11 UTC) #2
On 2013/09/27 23:53:50, thomasmorley651 wrote:
> LGTM
> 
> Question: 
> considering LSR-update, I recently added an earlier version of it to the LSR
> http://lsr.dsi.unimi.it/LSR/Item?id=887
> Should I replace it with this one?

I think that depends on whether it will compile with the current LSR version. 
This version will work either before or after issue 2240 (one motivation for the
change) but it might require code not available in 2.14.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b