Issue 138150043: Issue 346: monochord issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138150043: Issue 346: monochord issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by dak

Modified:
9 years, 6 months ago

Reviewers:
Keith, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 346: monochord issues This lets a reverse notehead at the stem start creep up closer to its same-pitch unreversed partner in order to avoid a gap caused by notehead slant.

Patch Set 2 : Move whole notes towards one another in a different manner #

Total comments: 1

Patch Set 3 : Backpedal on semibreves #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
	A	input/regression/monochords.ly	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
	M	lily/stem.cc	View	1 2	1 chunk	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Keith

https://codereview.appspot.com/138150043/diff/20001/lily/stem.cc File lily/stem.cc (right): https://codereview.appspot.com/138150043/diff/20001/lily/stem.cc#newcode597 lily/stem.cc:597: reverse_overlap = 0.1; This seems not enough overlap to ...

9 years, 7 months ago (2014-09-06 18:57:10 UTC) #2

LGTM, thanks.

Expand All Messages | Collapse All Messages