Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

Issue 13781043: panic if we get bad requests

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jameinel
Modified:
10 years, 6 months ago
Reviewers:
gz, mp+186500
Visibility:
Public.

Description

panic if we get bad requests It turns out that if you don't supply CIDR or GroupId Openstack just sets CIDR to 0.0.0.0/0. We don't want to rely on that behavior, so this just changes the goose test double to panic if it got that situation. This can't land until we land my updated Juju branch (or the test suite will appropriately fail with panic().) https://code.launchpad.net/~jameinel/goose/security-group-rule-group-id-1226996/+merge/186500 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M testservices/novaservice/service.go View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years, 6 months ago (2013-09-19 10:57:36 UTC) #1
gz
10 years, 6 months ago (2013-09-19 15:13:26 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b